From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 08 Aug 2006 13:57:27 +0100 (BST) Received: from bender.bawue.de ([193.7.176.20]:36244 "EHLO bender.bawue.de") by ftp.linux-mips.org with ESMTP id S20041147AbWHHM5W (ORCPT ); Tue, 8 Aug 2006 13:57:22 +0100 Received: from lagash (mipsfw.mips-uk.com [194.74.144.146]) (using TLSv1 with cipher DES-CBC3-SHA (168/168 bits)) (No client certificate requested) by bender.bawue.de (Postfix) with ESMTP id 5043D44856; Tue, 8 Aug 2006 14:57:18 +0200 (MEST) Received: from ths by lagash with local (Exim 4.62) (envelope-from ) id 1GAR7s-00084a-5z; Tue, 08 Aug 2006 13:56:04 +0100 Date: Tue, 8 Aug 2006 13:56:04 +0100 To: Franck Bui-Huu Cc: linux-mips@linux-mips.org, anemo@mba.ocn.ne.jp, ralf@linux-mips.org, yoichi_yuasa@tripeaks.co.jp Subject: Re: [PATCH 6/6] setup.c: use early_param() for early command line parsing Message-ID: <20060808125604.GI29989@networkno.de> References: <1155041312273-git-send-email-vagabon.xyz@gmail.com> <1155041313139-git-send-email-vagabon.xyz@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1155041313139-git-send-email-vagabon.xyz@gmail.com> User-Agent: Mutt/1.5.12-2006-07-14 From: Thiemo Seufer Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 12239 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ths@networkno.de Precedence: bulk X-list: linux-mips Franck Bui-Huu wrote: > There's no point to rewrite some logic to parse command line > to pass initrd parameters or to declare a user memory area. > We could use instead parse_early_param() that does the same > thing. > > NOTE ! This patch also changes the initrd semantic. Old code > was expecting "rd_start=xxx rd_size=xxx" which uses two > parameters. Now the code expects "initrd=xxx@yyy" which is > really simpler to parse and to use. No default config files > use these parameters anyways but not sure for bootloader's > users... This code is there precisely because most mips bootloaders use rd_start/rd_size. It also is IMHO a bad idea to overload the semantics of initrd= with both file names and memory locations. Thiemo