From: Christoph Hellwig <hch@lst.de>
To: Dave Wysochanski <davidw@netapp.com>
Cc: Christoph Hellwig <hch@lst.de>,
usb-storage@lists.one-eyed-alien.net, stern@rowland.harvard.edu,
James.Bottomley@steeleye.com, michaelc@cs.wisc.edu,
linux-scsi@vger.kernel.org, hare@suse.de, "Kraft,
Claire" <Claire.Kraft@netapp.com>,
"Shenoy, Raghavendra" <Raghavendra.Shenoy@netapp.com>,
"George, Martin" <marting@netapp.com>,
"Nair, Vinod K" <nvinod@netapp.com>
Subject: Re: [PATCH] Don't add scsi_device for devices that return PQ=1, PDT=0x1f
Date: Tue, 8 Aug 2006 17:34:17 +0200 [thread overview]
Message-ID: <20060808153417.GA1542@lst.de> (raw)
In-Reply-To: <44D6D79E.3020304@netapp.com>
On Mon, Aug 07, 2006 at 02:03:10AM -0400, Dave Wysochanski wrote:
> I'm not sure Alan's pdt_1f_for_no_lun flag should be used in my case,
> since I would want to set it based on vid/pid
I don't think we should set any flag for the netapp behaviour. It might
be stretching the standard a little, but it's not completely odd and I
can't think of anything bad that could hapen if we do it unconditonally.
Something like:
if ((result[0] >> 5) == 1 || starget->some_flag) &&
(result[0] & 0x1f) == 0x1f) {
SCSI_LOG_SCAN_BUS(3, printk(KERN_INFO
"scsi scan: peripheral device type"
" of 31, no device added\n"));
res = SCSI_SCAN_TARGET_PRESENT;
goto out_free_result;
}
prev parent reply other threads:[~2006-08-08 15:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-27 20:30 [PATCH] Don't add scsi_device for devices that return PQ=1, PDT=0x1f Dave Wysochanski
2006-08-05 12:01 ` Christoph Hellwig
2006-08-07 6:03 ` Dave Wysochanski
2006-08-07 14:45 ` Alan Stern
2006-08-08 15:34 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060808153417.GA1542@lst.de \
--to=hch@lst.de \
--cc=Claire.Kraft@netapp.com \
--cc=James.Bottomley@steeleye.com \
--cc=Raghavendra.Shenoy@netapp.com \
--cc=davidw@netapp.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=marting@netapp.com \
--cc=michaelc@cs.wisc.edu \
--cc=nvinod@netapp.com \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.