All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: [PATCH 2/4] autoconf: Error out on --without-shell and --without-perl
Date: Tue, 8 Aug 2006 18:36:21 +0200	[thread overview]
Message-ID: <200608081836.21614.jnareb@gmail.com> (raw)
In-Reply-To: <200608081834.09271.jnareb@gmail.com>

Error out on --without-shell/--with-shell=no and
--without-perl/--with-perl=no instead of just warning
and continuing.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
It's a matter of taste (and not doing unexpected)

 configure.ac |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/configure.ac b/configure.ac
index e2da891..c2ddd9b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -37,7 +37,7 @@ # Used by GIT_ARG_SET_PATH(PROGRAM)
 AC_DEFUN([GIT_CONF_APPEND_PATH],
 [PROGRAM=m4_toupper($1); \
 if test "$withval" = "no"; then \
-	AC_MSG_WARN([You cannot use git without $1]); \
+	AC_MSG_ERROR([You cannot use git without $1]); \
 else \
 	if test "$withval" = "yes"; then \
 		AC_MSG_WARN([You should provide path for --with-$1=PATH]); \
-- 
1.4.1.1

  parent reply	other threads:[~2006-08-08 16:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-08 16:34 [PATCH 0/4] autoconf: Some improvements Jakub Narebski
2006-08-08 16:35 ` [PATCH 1/4] autoconf: Add configure target to main Makefile Jakub Narebski
2006-08-08 16:48   ` [PATCH 5/4] autoconf: Mention "make configure" instead of "autoconf" in INSTALL Jakub Narebski
2006-08-08 16:36 ` Jakub Narebski [this message]
2006-08-08 16:38 ` [PATCH 3/4] autoconf: Improvements in NO_PYTHON/PYTHON_PATH handling Jakub Narebski
2006-08-08 16:39 ` [PATCH 4/4] autoconf: Move variables which we always set to config.mak.in Jakub Narebski
2006-08-08 23:42   ` [PATCH 6/4] autoconf: Add forgotten NO_OPENSSL=@NO_OPENSSL@ " Jakub Narebski
2006-08-08 20:43 ` [PATCH] autoconf: clean temporary file mak.append Junio C Hamano
2006-08-08 20:58   ` Jakub Narebski
2006-08-08 21:35     ` Junio C Hamano
2006-08-09  0:15 ` [PATCH 7] autoconf: Add support for setting CURLDIR, OPENSSLDIR, EXPATDIR Jakub Narebski
2006-08-10 10:50   ` Jakub Narebski
2006-08-10 21:27     ` Junio C Hamano
2006-08-10 21:43       ` Jakub Narebski
2006-08-09  0:19 ` [PATCH 8] autoconf: It is --without-python, not --no-python Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200608081836.21614.jnareb@gmail.com \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.