From: Al Viro <viro@ftp.linux.org.uk>
To: Kirill Korotaev <dev@sw.ru>
Cc: Andrew Morton <akpm@osdl.org>,
viro@zeniv.linux.org.uk,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mishin Dmitry <dim@openvz.org>
Subject: Re: [PATCH] move IMMUTABLE|APPEND checks to notify_change()
Date: Tue, 8 Aug 2006 21:38:14 +0100 [thread overview]
Message-ID: <20060808203814.GO29920@ftp.linux.org.uk> (raw)
In-Reply-To: <44D87907.6090706@sw.ru>
On Tue, Aug 08, 2006 at 03:44:07PM +0400, Kirill Korotaev wrote:
> [PATCH] move IMMUTABLE|APPEND checks to notify_change()
>
> This patch moves lots of IMMUTABLE and APPEND flag checks
> scattered all around to more logical place in notify_change().
NAK. For example, you are allowed to do unames(file, NULL) on
any file you own or can write to, whether it's append-only or
not. With your change that gets -EPERM.
next prev parent reply other threads:[~2006-08-08 20:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-08 11:44 [PATCH] move IMMUTABLE|APPEND checks to notify_change() Kirill Korotaev
2006-08-08 20:38 ` Al Viro [this message]
2006-08-09 7:15 ` Dmitry Mishin
2006-08-09 14:11 ` Al Viro
2006-08-09 9:07 ` Kirill Korotaev
2006-08-09 10:11 ` Kirill Korotaev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060808203814.GO29920@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=akpm@osdl.org \
--cc=dev@sw.ru \
--cc=dim@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.