From: David Miller <davem@davemloft.net>
To: davej@redhat.com
Cc: shemminger@osdl.org, acme@ghostprotocols.net,
netdev@vger.kernel.org, greg@kroah.com
Subject: Re: IPX changes introduce warning.
Date: Wed, 09 Aug 2006 17:36:48 -0700 (PDT) [thread overview]
Message-ID: <20060809.173648.77057307.davem@davemloft.net> (raw)
In-Reply-To: <20060809234417.GA23634@redhat.com>
From: Dave Jones <davej@redhat.com>
Date: Wed, 9 Aug 2006 19:44:17 -0400
> We've just added an implicit declaration in the latest tree..
>
> net/ipx/af_ipx.c: In function 'ipx_rcv':
> net/ipx/af_ipx.c:1648: error: implicit declaration of function 'ipxhdr'
>
> (Yes, my builds fail on -Werror-implicit, so that things like this get caught early)
>
> Probably something simple like a missing #include, but I'm heading out
> the door right now :) I'll poke at it later if no-one has beaten me to it.
I could have sworn this compiled in my tree, sorry.
Fix below. Greg, I'll queue this up to you in a GIT tree along
with another fix later tonight.
Thanks Dave.
commit fff642570dc47ab76491fe81ee6599269c4eb13e
Author: David S. Miller <davem@sunset.davemloft.net>
Date: Wed Aug 9 17:36:15 2006 -0700
[IPX]: Fix typo, ipxhdr() --> ipx_hdr()
Noticed by Dave Jones.
Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/net/ipx/af_ipx.c b/net/ipx/af_ipx.c
index 4019642..bef3f61 100644
--- a/net/ipx/af_ipx.c
+++ b/net/ipx/af_ipx.c
@@ -1645,7 +1645,7 @@ static int ipx_rcv(struct sk_buff *skb,
if (!pskb_may_pull(skb, sizeof(struct ipxhdr)))
goto drop;
- ipx_pktsize = ntohs(ipxhdr(skb)->ipx_pktsize);
+ ipx_pktsize = ntohs(ipx_hdr(skb)->ipx_pktsize);
/* Too small or invalid header? */
if (ipx_pktsize < sizeof(struct ipxhdr) ||
prev parent reply other threads:[~2006-08-10 0:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-09 23:44 IPX changes introduce warning Dave Jones
2006-08-10 0:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060809.173648.77057307.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=acme@ghostprotocols.net \
--cc=davej@redhat.com \
--cc=greg@kroah.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.