All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ewan Mellor <ewan@xensource.com>
To: John Levon <levon@movementarian.org>
Cc: xen-ppc-devel <xen-ppc-devel@lists.xensource.com>,
	xen-devel <xen-devel@lists.xensource.com>,
	Hollis Blanchard <hollisb@us.ibm.com>,
	xen-ia64-devel <xen-ia64-devel@lists.xensource.com>
Subject: Re: architecture-specific stuff in xend
Date: Wed, 9 Aug 2006 10:28:10 +0100	[thread overview]
Message-ID: <20060809092810.GC19705@leeni.uk.xensource.com> (raw)
In-Reply-To: <20060808155953.GA20410@totally.trollied.org>

On Tue, Aug 08, 2006 at 04:59:53PM +0100, John Levon wrote:

> On Tue, Aug 08, 2006 at 10:34:25AM -0500, Hollis Blanchard wrote:
> 
> > Rather than having these inline tests everywhere ("if os.uname()[4] in
> > ('ia64', 'ppc64'):"), would it make more sense to have some sort of
> > "architecture" object, and do things like:
> 
> It'd be good if it were slightly more general and covered other system
> stuff too (namely OS). On Solaris some of the Xen binaries/scripts live
> in different locations in order to meet our file system requirements.
> 
> > I'm not sure how/where to instantiate the arch object though.
> 
> Presumably you could do the instance() singleton trick?

This being Python, you don't actually need singletons -- the containing module
is a singleton in its own right.  You can just write

Platform.py:

import os

if os.uname()[4] in ('ia64', 'ppc64'):
    def init_reservation(mem_kb):
        return something_else(mem_kb)

else:
    def init_reservation(mem_kb):
        return mem_kb

and then

import Platform
Platform.init_reservation(100)

will do the right thing.

Ewan.

  parent reply	other threads:[~2006-08-09  9:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-08 15:34 architecture-specific stuff in xend Hollis Blanchard
2006-08-08 15:59 ` [XenPPC] Re: [Xen-devel] " John Levon
2006-08-08 16:15   ` Hollis Blanchard
2006-08-08 17:12     ` John Levon
2006-08-09  9:28   ` Ewan Mellor [this message]
2006-08-09 15:07     ` Hollis Blanchard
2006-08-09 16:18       ` Ewan Mellor
2006-08-10 21:12         ` [PATCH] " Hollis Blanchard
2006-08-10 21:27           ` John Levon
2006-08-11 22:59           ` Daniel Miles
2006-08-14 17:40         ` Hollis Blanchard
2006-08-15  2:14           ` Hollis Blanchard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060809092810.GC19705@leeni.uk.xensource.com \
    --to=ewan@xensource.com \
    --cc=hollisb@us.ibm.com \
    --cc=levon@movementarian.org \
    --cc=xen-devel@lists.xensource.com \
    --cc=xen-ia64-devel@lists.xensource.com \
    --cc=xen-ppc-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.