From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [RFC][PATCH -mm 1/5] swsusp: Introduce memory bitmaps Date: Wed, 9 Aug 2006 12:57:16 +0200 Message-ID: <200608091257.16663.rjw@sisk.pl> References: <200608091152.49094.rjw@sisk.pl> <200608091158.38458.rjw@sisk.pl> <20060809103120.GI3308@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20060809103120.GI3308@elf.ucw.cz> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.osdl.org Errors-To: linux-pm-bounces@lists.osdl.org To: Pavel Machek Cc: Linux PM , LKML List-Id: linux-pm@vger.kernel.org Hi, On Wednesday 09 August 2006 12:31, Pavel Machek wrote: > > Introduce the memory bitmap data structure and make swsusp use in the s= uspend > > phase. > > = > > The current swsusp's internal data structure is not very efficient from= the > > memory usage point of view, so it seems reasonable to replace it with a= data > > structure that will require less memory, such as a pair of bitmaps. > = > Well, 500 lines of code for what... 0.25% bigger image? I see it > enables you to do some cleanups... but could we get those cleanups > without those 500 lines? :-). Out of the 500 lines, something like 100 are comments and other 50 are definitions of structures. ;-) Seriously speaking, I could do that without the bitmaps, but the code would= n't be that much shorter. Apart from this, I would need to introduce yet anoth= er type of PBEs (for storing pfns) and try not to get lost in the resulting me= ss. Instead of doing this I prefer to add some extra code to set up a decent da= ta structure and just use it. Rafael From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030680AbWHILH0 (ORCPT ); Wed, 9 Aug 2006 07:07:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030616AbWHILH0 (ORCPT ); Wed, 9 Aug 2006 07:07:26 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:3039 "EHLO ogre.sisk.pl") by vger.kernel.org with ESMTP id S1030680AbWHILHY (ORCPT ); Wed, 9 Aug 2006 07:07:24 -0400 From: "Rafael J. Wysocki" To: Pavel Machek Subject: Re: [RFC][PATCH -mm 1/5] swsusp: Introduce memory bitmaps Date: Wed, 9 Aug 2006 12:57:16 +0200 User-Agent: KMail/1.9.3 Cc: LKML , Linux PM References: <200608091152.49094.rjw@sisk.pl> <200608091158.38458.rjw@sisk.pl> <20060809103120.GI3308@elf.ucw.cz> In-Reply-To: <20060809103120.GI3308@elf.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200608091257.16663.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wednesday 09 August 2006 12:31, Pavel Machek wrote: > > Introduce the memory bitmap data structure and make swsusp use in the suspend > > phase. > > > > The current swsusp's internal data structure is not very efficient from the > > memory usage point of view, so it seems reasonable to replace it with a data > > structure that will require less memory, such as a pair of bitmaps. > > Well, 500 lines of code for what... 0.25% bigger image? I see it > enables you to do some cleanups... but could we get those cleanups > without those 500 lines? :-). Out of the 500 lines, something like 100 are comments and other 50 are definitions of structures. ;-) Seriously speaking, I could do that without the bitmaps, but the code wouldn't be that much shorter. Apart from this, I would need to introduce yet another type of PBEs (for storing pfns) and try not to get lost in the resulting mess. Instead of doing this I prefer to add some extra code to set up a decent data structure and just use it. Rafael