From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
To: David Howells <dhowells@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org,
Prasanna S Panchamukhi <prasanna@in.ibm.com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
Jim Keniston <jkenisto@us.ibm.com>,
linux-arch@vger.kernel.org
Subject: Re: [PATCH 2/3] Kprobes: Define retval helper
Date: Wed, 9 Aug 2006 20:50:18 +0530 [thread overview]
Message-ID: <20060809152018.GA17486@in.ibm.com> (raw)
In-Reply-To: <26750.1155129364@warthog.cambridge.redhat.com>
On Wed, Aug 09, 2006 at 02:16:04PM +0100, David Howells wrote:
> Christoph Hellwig <hch@infradead.org> wrote:
>
> > > > Good idea. You should add parentheses around regs, otherwise the C
> > > > preprocessor might bite users. Also the shouting name is quite ugly.
> > > > In fact it should probably go to asm/system.h or similar and not have
> > > > a kprobes name - it just extracts the return value from a struct pt_regs
> > > > after all.
> > >
> > > Done! How does this look? I added it to asm/ptrace.h so it lives along
> > > with the instruction_pointer() definition.
>
> I presume we don't care about return values that span multiple registers - for
> instance if you return a 64-bit value on i386 it'll wind up in EDX:EAX.
Yes. This helper is mostly to address the common case, not the 64-bit
one.
Ananth
next prev parent reply other threads:[~2006-08-09 15:19 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-07 11:55 [PATCH 1/3] Kprobes: Make kprobe modules more portable Ananth N Mavinakayanahalli
2006-08-07 12:00 ` [PATCH 2/3] Kprobes: Define retval helper Ananth N Mavinakayanahalli
2006-08-07 12:04 ` [PATCH 3/3] Kprobes: Update Documentation/kprobes.txt Ananth N Mavinakayanahalli
2006-08-08 16:27 ` Christoph Hellwig
2006-08-09 9:48 ` Ananth N Mavinakayanahalli
2006-08-09 10:24 ` Ananth N Mavinakayanahalli
2006-08-08 16:25 ` [PATCH 2/3] Kprobes: Define retval helper Christoph Hellwig
2006-08-09 4:37 ` Andi Kleen
2006-08-09 9:43 ` Ananth N Mavinakayanahalli
2006-08-09 9:45 ` Christoph Hellwig
2006-08-09 9:55 ` Andi Kleen
2006-08-09 10:19 ` Ananth N Mavinakayanahalli
2006-08-09 10:28 ` Martin Schwidefsky
2006-08-09 13:16 ` David Howells
2006-08-09 15:20 ` Ananth N Mavinakayanahalli [this message]
2006-08-07 12:06 ` [PATCH 1/3] Kprobes: Make kprobe modules more portable Ananth N Mavinakayanahalli
2006-08-08 16:24 ` Christoph Hellwig
2006-08-08 16:34 ` Stephen Hemminger
2006-08-08 16:40 ` Christoph Hellwig
2006-08-08 17:28 ` Paulo Marques
2006-08-08 17:32 ` Christoph Hellwig
2006-08-09 9:51 ` Ananth N Mavinakayanahalli
2006-08-09 16:01 ` David Smith
2006-08-09 16:10 ` Christoph Hellwig
2006-08-09 16:18 ` Christoph Hellwig
2006-08-10 14:10 ` Keshavamurthy Anil S
2006-08-16 13:20 ` Christoph Hellwig
2006-08-11 8:53 ` Ananth N Mavinakayanahalli
2006-08-10 6:18 ` Ananth N Mavinakayanahalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060809152018.GA17486@in.ibm.com \
--to=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=jkenisto@us.ibm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prasanna@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.