From: Anton Blanchard <anton@samba.org>
To: Jan-Bernd Themann <ossthema@de.ibm.com>
Cc: Thomas Klein <tklein@de.ibm.com>, netdev <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-ppc <linuxppc-dev@ozlabs.org>,
Christoph Raisch <raisch@de.ibm.com>,
Marcus Eder <meder@de.ibm.com>
Subject: Re: [PATCH 2/6] ehea: pHYP interface
Date: Sat, 12 Aug 2006 07:13:14 +1000 [thread overview]
Message-ID: <20060811211314.GF479@krispykreme> (raw)
In-Reply-To: <44D99F1A.4080905@de.ibm.com>
Hi,
> --- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_phyp.c 1969-12-31 16:00:00.000000000 -0800
> +u64 ehea_h_alloc_resource_eq(const u64 hcp_adapter_handle,
...
> +u64 hipz_h_reregister_pmr(const u64 adapter_handle,
...
> +static inline int hcp_galpas_ctor(struct h_galpas *galpas,
Be nice to have some consistent names, hipz_ and hcp_ is kind of
cryptic.
> +#define H_QP_CR_STATE_RESET 0x0000010000000000 /* Reset */
Probably want ULL on here and the other 64bit constants.
Anton
WARNING: multiple messages have this Message-ID (diff)
From: Anton Blanchard <anton@samba.org>
To: Jan-Bernd Themann <ossthema@de.ibm.com>
Cc: netdev <netdev@vger.kernel.org>, Thomas Klein <tklein@de.ibm.com>,
linux-ppc <linuxppc-dev@ozlabs.org>,
Christoph Raisch <raisch@de.ibm.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Marcus Eder <meder@de.ibm.com>
Subject: Re: [PATCH 2/6] ehea: pHYP interface
Date: Sat, 12 Aug 2006 07:13:14 +1000 [thread overview]
Message-ID: <20060811211314.GF479@krispykreme> (raw)
In-Reply-To: <44D99F1A.4080905@de.ibm.com>
Hi,
> --- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_phyp.c 1969-12-31 16:00:00.000000000 -0800
> +u64 ehea_h_alloc_resource_eq(const u64 hcp_adapter_handle,
...
> +u64 hipz_h_reregister_pmr(const u64 adapter_handle,
...
> +static inline int hcp_galpas_ctor(struct h_galpas *galpas,
Be nice to have some consistent names, hipz_ and hcp_ is kind of
cryptic.
> +#define H_QP_CR_STATE_RESET 0x0000010000000000 /* Reset */
Probably want ULL on here and the other 64bit constants.
Anton
next prev parent reply other threads:[~2006-08-11 21:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-09 8:38 [PATCH 2/6] ehea: pHYP interface Jan-Bernd Themann
2006-08-09 8:38 ` Jan-Bernd Themann
2006-08-09 13:14 ` Arnd Bergmann
2006-08-09 13:14 ` Arnd Bergmann
2006-08-09 13:14 ` Arnd Bergmann
2006-08-10 15:12 ` Thomas Klein
2006-08-10 15:12 ` Thomas Klein
2006-08-11 21:13 ` Anton Blanchard [this message]
2006-08-11 21:13 ` Anton Blanchard
2006-08-14 13:14 ` Jan-Bernd Themann
2006-08-14 13:14 ` Jan-Bernd Themann
2006-08-11 21:19 ` Nathan Lynch
2006-08-11 21:19 ` Nathan Lynch
2006-08-11 21:26 ` Nathan Lynch
2006-08-21 12:04 ` Jan-Bernd Themann
2006-08-21 12:04 ` Jan-Bernd Themann
-- strict thread matches above, loose matches on Subject: below --
2006-06-21 12:40 Jan-Bernd Themann
2006-06-21 15:36 ` Roland Dreier
2006-06-26 16:17 ` Heiko J Schick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060811211314.GF479@krispykreme \
--to=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=meder@de.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ossthema@de.ibm.com \
--cc=raisch@de.ibm.com \
--cc=tklein@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.