From mboxrd@z Thu Jan 1 00:00:00 1970 From: kupcevic@sourceware.org Date: 12 Aug 2006 00:38:37 -0000 Subject: [Cluster-devel] conga/ricci common/executils.cpp ricci/Auth.cpp Message-ID: <20060812003837.3932.qmail@sourceware.org> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit CVSROOT: /cvs/cluster Module name: conga Changes by: kupcevic at sourceware.org 2006-08-12 00:38:36 Modified files: ricci/common : executils.cpp ricci/ricci : Auth.cpp Log message: ricci: fd leak Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/conga/ricci/common/executils.cpp.diff?cvsroot=cluster&r1=1.6&r2=1.7 http://sourceware.org/cgi-bin/cvsweb.cgi/conga/ricci/ricci/Auth.cpp.diff?cvsroot=cluster&r1=1.3&r2=1.4 --- conga/ricci/common/executils.cpp 2006/08/10 22:53:07 1.6 +++ conga/ricci/common/executils.cpp 2006/08/12 00:38:36 1.7 @@ -102,7 +102,7 @@ // close open fds for (unsigned int i=3; i<__FD_SETSIZE; i++) - close(i); + close_fd(i); // restore signals for (int x = 1; x < _NSIG; x++) --- conga/ricci/ricci/Auth.cpp 2006/08/10 22:53:09 1.3 +++ conga/ricci/ricci/Auth.cpp 2006/08/12 00:38:36 1.4 @@ -114,10 +114,10 @@ pass = pass.substr(size, pass.npos); } while (!pass.empty()); } catch ( ... ) { - close_fd(_stdin_pipe[0]); + close_fd(_stdin_pipe[1]); throw; } - close_fd(_stdin_pipe[0]); + close_fd(_stdin_pipe[1]); bool success = false; int ret, status;