All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Graf <tgraf@suug.ch>
To: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH 1/4] [NETLINK]: Handle NLM_F_ECHO in netlink_rcv_skb()
Date: Sat, 12 Aug 2006 13:19:08 +0200	[thread overview]
Message-ID: <20060812111908.GP14627@postel.suug.ch> (raw)
In-Reply-To: <20060812110331.GA31479@ms2.inr.ac.ru>

* Alexey Kuznetsov <kuznet@ms2.inr.ac.ru> 2006-08-12 15:03
> Actually, it was the idea. If requestor asked NLM_F_ECHO and subscribed
> to muticasts, it suppresses double notifications. If it did not ask
> NLM_F_ECHO, he is not interested in results, he knows what's going on
> without this.
> 
> F.e. it was used by my implementation in gated: it did not set either
> NLM_F_ECHO or even NLM_F_ACK. And when making massive batch updates,
> it received nothing back: only errors and updates made by someone else.

So we do something like this:

/**
 * nlmsg_notify - send a notification netlink message
 * @sk: netlink socket to use
 * @skb: notification message
 * @pid: destination netlink pid for reports or 0
 * @group: destination multicast group or 0
 * @report: 1 to report back, 0 to disable
 * @flags: allocation flags
 */
int nlmsg_notify(struct sock *sk, struct sk_buff *skb, u32 pid,
		 unsigned int group, int report, gfp_t flags)
{
	int err = 0;

	if (group) {
		int exclude_pid = 0;

		if (report) {
			atomic_inc(&skb->users);
			exclude_pid = pid;
		}

		/* errors reported via destination sk->sk_err */
		nlmsg_multicast(sk, skb, exclude_pid, group, flags);
	}

	if (report)
		err = nlmsg_unicast(sk, skb, pid);

	return err;
}

  reply	other threads:[~2006-08-12 11:18 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-09 20:48 [PATCHSET]: Clean up netlink NLM_F_ECHO and rtnl event notifications Thomas Graf
2006-08-08 22:00 ` [PATCH 1/4] [NETLINK]: Handle NLM_F_ECHO in netlink_rcv_skb() Thomas Graf
2006-08-10 15:51   ` Alexey Kuznetsov
2006-08-10 19:02     ` Thomas Graf
2006-08-10 20:32       ` Alexey Kuznetsov
2006-08-10 21:18         ` Thomas Graf
2006-08-11 15:35           ` Alexey Kuznetsov
2006-08-11 21:47             ` Thomas Graf
2006-08-12 11:03               ` Alexey Kuznetsov
2006-08-12 11:19                 ` Thomas Graf [this message]
2006-08-13 13:45                   ` Alexey Kuznetsov
2006-08-12  3:05             ` Herbert Xu
2006-08-12 11:05               ` Alexey Kuznetsov
2006-08-08 22:00 ` [PATCH 2/4] [RTNETLINK]: Use rtnl_multicast()/rtnl_unicast() Thomas Graf
2006-08-09 21:00   ` [RESEND " Thomas Graf
2006-08-08 22:00 ` [PATCH 3/4] [NETLINK]: Dont set socket error for failed event notifications Thomas Graf
2006-08-10 18:09   ` Patrick McHardy
2006-08-10 19:04     ` Thomas Graf
2006-08-10 19:08       ` Patrick McHardy
2006-08-10 19:23         ` Thomas Graf
2006-08-11  6:02           ` David Miller
2006-08-11 10:38             ` Thomas Graf
2006-08-11 10:42               ` David Miller
2006-08-08 22:00 ` [PATCH 4/4] [RTNETLINK]: Unexport global rtnl sock Thomas Graf
2006-08-10  4:16 ` [PATCHSET]: Clean up netlink NLM_F_ECHO and rtnl event notifications David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060812111908.GP14627@postel.suug.ch \
    --to=tgraf@suug.ch \
    --cc=davem@davemloft.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.