From: Michael Buesch <mb@bu3sch.de>
To: Daniel Drake <dsd@gentoo.org>
Cc: linville@tuxdriver.com, netdev@vger.kernel.org, kune@deine-taler.de
Subject: Re: [PATCH] zd1211rw: cleanups
Date: Sun, 13 Aug 2006 11:24:34 +0200 [thread overview]
Message-ID: <200608131124.34935.mb@bu3sch.de> (raw)
In-Reply-To: <20060812170017.278D08E7782@zog.reactivated.net>
On Saturday 12 August 2006 19:00, Daniel Drake wrote:
> --- linux-2.6.orig/drivers/net/wireless/zd1211rw/zd_mac.c
> +++ linux-2.6/drivers/net/wireless/zd1211rw/zd_mac.c
> @@ -127,11 +127,9 @@ out:
>
> void zd_mac_clear(struct zd_mac *mac)
> {
> - /* Aquire the lock. */
> - spin_lock(&mac->lock);
> - spin_unlock(&mac->lock);
> zd_chip_clear(&mac->chip);
> - memset(mac, 0, sizeof(*mac));
> + ZD_ASSERT(!spin_is_locked(&mac->lock));
I think this assertion will always trigger on UP kernels
with spinlock debugging disabled.
--
Greetings Michael.
next prev parent reply other threads:[~2006-08-13 9:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-12 17:00 [PATCH] zd1211rw: cleanups Daniel Drake
2006-08-13 9:24 ` Michael Buesch [this message]
2006-08-13 9:50 ` Ulrich Kunitz
-- strict thread matches above, loose matches on Subject: below --
2006-11-22 0:05 Daniel Drake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608131124.34935.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=dsd@gentoo.org \
--cc=kune@deine-taler.de \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.