From: Andi Kleen <ak@suse.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, johnpol@2ka.mipt.ru
Subject: Re: skb_shared_info()
Date: Mon, 14 Aug 2006 09:45:53 +0200 [thread overview]
Message-ID: <200608140945.53713.ak@suse.de> (raw)
In-Reply-To: <20060814072903.GA14138@gondor.apana.org.au>
On Monday 14 August 2006 09:29, Herbert Xu wrote:
> On Mon, Aug 14, 2006 at 07:04:01AM +0200, Andi Kleen wrote:
> >
> > Another reason to move it in the sk_buff would be better cache
> > coloring? Currently on large/small MTU packets it will be always on
> > the same colors.
>
> If we went with a fully paged skbs this should be a non-issue, right?
Even for 1.5k MTU? (which is still the most common case after all)
> In a fully paged representation the head would be small which is the
> perfect place to place the skb_shared_info.
If the head is small and allocated with kmalloc then slab should
color it yes. It won't for big allocations.
-Andi
next prev parent reply other threads:[~2006-08-14 7:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-08 23:39 skb_shared_info() David Miller
2006-08-09 0:36 ` skb_shared_info() Herbert Xu
2006-08-09 0:58 ` skb_shared_info() David Miller
2006-08-09 5:35 ` skb_shared_info() Evgeniy Polyakov
2006-08-09 5:50 ` skb_shared_info() David Miller
2006-08-10 19:49 ` skb_shared_info() Evgeniy Polyakov
2006-08-11 14:00 ` skb_shared_info() Alexey Kuznetsov
2006-08-12 0:27 ` skb_shared_info() David Miller
2006-08-12 0:32 ` skb_shared_info() Herbert Xu
2006-08-13 13:04 ` skb_shared_info() Alexey Kuznetsov
2006-08-14 8:01 ` skb_shared_info() Evgeniy Polyakov
2006-08-14 13:19 ` skb_shared_info() Alexey Kuznetsov
2006-08-14 13:38 ` skb_shared_info() Evgeniy Polyakov
2006-08-15 11:30 ` skb_shared_info() Alexey Kuznetsov
2006-08-14 5:04 ` skb_shared_info() Andi Kleen
2006-08-14 7:29 ` skb_shared_info() Herbert Xu
2006-08-14 7:45 ` Andi Kleen [this message]
2006-08-14 7:50 ` skb_shared_info() Herbert Xu
2006-08-14 8:18 ` skb_shared_info() Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608140945.53713.ak@suse.de \
--to=ak@suse.de \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=johnpol@2ka.mipt.ru \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.