From: Andi Kleen <ak@suse.de>
To: "Jan Beulich" <jbeulich@novell.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH for review] [127/145] i386: move kernel_thread_helper into entry.S
Date: Mon, 14 Aug 2006 14:39:07 +0200 [thread overview]
Message-ID: <200608141439.07038.ak@suse.de> (raw)
In-Reply-To: <44E08A76.76E4.0078.0@novell.com>
On Monday 14 August 2006 14:36, Jan Beulich wrote:
> >> And this too - the value now in %eax has no relation with the
> >> value known by the caller of this routine (which doesn't expect
> >> any return from here anyway).
> >
> >Ok, but somehow it needs to be annotiated so that the unwinder stops
> >and doesn't fall back. Can you please send a replacement patch that
> >does this correctly?
>
> Actually, with the previous attempt we still didn't achieve the
> original
> goal of terminating the frame chain at kernel_thread_helper. Thus
> another try (the seemingly odd extra push can be avoided once we
> start using CFI expressions, which the unwinder currently doesn't
> support):
I added the extra push thanks (hope there weren't more changes)
-Andi
next prev parent reply other threads:[~2006-08-14 12:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-14 12:36 [PATCH for review] [127/145] i386: move kernel_thread_helper into entry.S Jan Beulich
2006-08-14 12:39 ` Andi Kleen [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-08-15 10:36 Jan Beulich
2006-08-15 10:48 ` Andi Kleen
[not found] <20060810 935.775038000@suse.de>
2006-08-10 19:37 ` Andi Kleen
2006-08-11 8:33 ` Jan Beulich
2006-08-11 8:38 ` Andi Kleen
2006-08-11 9:48 ` Jan Beulich
2006-08-11 10:16 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608141439.07038.ak@suse.de \
--to=ak@suse.de \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.