From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 14 Aug 2006 23:57:58 +0100 (BST) Received: from p549F51CF.dip.t-dialin.net ([84.159.81.207]:44770 "EHLO p549F51CF.dip.t-dialin.net") by ftp.linux-mips.org with ESMTP id S20039720AbWHNW54 (ORCPT ); Mon, 14 Aug 2006 23:57:56 +0100 Received: from mx1.redhat.com ([66.187.233.31]:58062 "EHLO mx1.redhat.com") by lappi.linux-mips.net with ESMTP id S1100047AbWHNQ1A (ORCPT ); Mon, 14 Aug 2006 18:27:00 +0200 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k7EGQlJq010883; Mon, 14 Aug 2006 12:26:47 -0400 Received: from nwo.kernelslacker.org (vpn-248-1.boston.redhat.com [10.13.248.1]) by int-mx1.corp.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k7EGQeaX010036; Mon, 14 Aug 2006 12:26:41 -0400 Received: from nwo.kernelslacker.org (localhost.localdomain [127.0.0.1]) by nwo.kernelslacker.org (8.13.7/8.13.5) with ESMTP id k7EGQeBb027153; Mon, 14 Aug 2006 12:26:40 -0400 Received: (from davej@localhost) by nwo.kernelslacker.org (8.13.7/8.13.7/Submit) id k7EGQcUi027152; Mon, 14 Aug 2006 12:26:38 -0400 X-Authentication-Warning: nwo.kernelslacker.org: davej set sender to davej@redhat.com using -f Date: Mon, 14 Aug 2006 12:26:38 -0400 From: Dave Jones To: "Randy.Dunlap" Cc: Sam Ravnborg , Thomas Koeller , wim@iguana.be, linux-kernel@vger.kernel.org, Ralf Baechle , linux-mips@linux-mips.org Subject: Re: [PATCH] Added MIPS RM9K watchdog driver Message-ID: <20060814162638.GC15569@redhat.com> Mail-Followup-To: Dave Jones , "Randy.Dunlap" , Sam Ravnborg , Thomas Koeller , wim@iguana.be, linux-kernel@vger.kernel.org, Ralf Baechle , linux-mips@linux-mips.org References: <200608102319.13679.thomas@koeller.dyndns.org> <20060811205639.GK26930@redhat.com> <200608120149.23380.thomas@koeller.dyndns.org> <20060814141445.GA10763@nineveh.rivenstone.net> <20060814153033.GA25215@mars.ravnborg.org> <20060814092124.84f7ff3e.rdunlap@xenotime.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060814092124.84f7ff3e.rdunlap@xenotime.net> User-Agent: Mutt/1.4.2.2i Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 12337 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: davej@redhat.com Precedence: bulk X-list: linux-mips On Mon, Aug 14, 2006 at 09:21:24AM -0700, Randy.Dunlap wrote: > On Mon, 14 Aug 2006 17:30:33 +0200 Sam Ravnborg wrote: > > > On Mon, Aug 14, 2006 at 10:14:45AM -0400, Joseph Fannin wrote: > > > On Sat, Aug 12, 2006 at 01:49:23AM +0200, Thomas Koeller wrote: > > > > On Friday 11 August 2006 22:56, Dave Jones wrote: > > > > > On Thu, Aug 10, 2006 at 11:19:13PM +0200, > > > > > thomas@koeller.dyndns.org wrote: > > > > > > + > > > > > > +#include > > > > > > > > > > not needed. > > > > > > > > It is, otherwise I do not get CONFIG_WATCHDOG_NOWAYOUT. > > Yes you do - try it. > > make V=1 tells you that -include include/linux/autoconf.h pulls in > > the CONFIG_ definitions. > > Sure, autoconf.h is included, but I think his point is that > CONFIG_WATCHDOG_NOWAYOUT may not be defined there at all, > as in my 2.6.18-rc4 autoconf.h file, since my .config file says: > # CONFIG_WATCHDOG_NOWAYOUT is not set As Wim pointed out, linux/watchdog.h has this magick.. #ifdef CONFIG_WATCHDOG_NOWAYOUT #define WATCHDOG_NOWAYOUT 1 #else #define WATCHDOG_NOWAYOUT 0 #endif Which takes some of the ugly out of the drivers :-) Dave -- http://www.codemonkey.org.uk