From: Adrian Bunk <bunk@stusta.de>
To: Bob Moore <robert.moore@intel.com>, Len Brown <len.brown@intel.com>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [2.6 patch] drivers/acpi/osl.c: fix a NULL check
Date: Tue, 15 Aug 2006 02:41:57 +0200 [thread overview]
Message-ID: <20060815004157.GF3543@stusta.de> (raw)
This patch fixes a non-working NULL check introduced by commit
b229cf92eee616c7cb5ad8cdb35a19b119f00bc8.
Spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.18-rc4-mm1/drivers/acpi/osl.c.old 2006-08-15 00:43:30.000000000 +0200
+++ linux-2.6.18-rc4-mm1/drivers/acpi/osl.c 2006-08-15 00:43:55.000000000 +0200
@@ -1030,7 +1030,7 @@
acpi_os_create_cache(char *name, u16 size, u16 depth, acpi_cache_t ** cache)
{
*cache = kmem_cache_create(name, size, 0, 0, NULL, NULL);
- if (cache == NULL)
+ if (*cache == NULL)
return AE_ERROR;
else
return AE_OK;
next reply other threads:[~2006-08-15 0:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-15 0:41 Adrian Bunk [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-11-20 21:06 [2.6 patch] drivers/acpi/osl.c: fix a NULL check Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060815004157.GF3543@stusta.de \
--to=bunk@stusta.de \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.