From: Pavel Machek <pavel@suse.cz>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] Add poll_event* interfaces (was Re: [patch] fix
Date: Tue, 15 Aug 2006 10:08:09 +0000 [thread overview]
Message-ID: <20060815100809.GF7496@elf.ucw.cz> (raw)
In-Reply-To: <20060812062818.GD4919@us.ibm.com>
Hi!
> > I think while you are hiding complexity in a macro, you should hide
> > the absolute time to jiffies conversion complexity(although not that
> > complex) too. It _is_ closely related to the interfaces you are
> > writing and in a lot of cases will probably be the only place the
> > conversion is used. So I say, bung it in there.
>
> Ok, below is my attempt at incorporating this. Also fixed a typo in
> poll_event_interruptible_timeout() and made a similar fix as 2) for
> the interruptible variants, where the condition takes precendence over a
> signal.
Agreed, looks okay to me.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2006-08-15 10:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-12 6:28 [KJ] [PATCH] Add poll_event* interfaces (was Re: [patch] fix common Nishanth Aravamudan
2006-08-13 22:42 ` [KJ] [PATCH] Add poll_event* interfaces (was Re: [patch] fix Pavel Machek
2006-08-13 23:41 ` Darren Jenkins
2006-08-14 4:12 ` Nishanth Aravamudan
2006-08-14 4:34 ` Darren Jenkins
2006-08-14 5:28 ` Nishanth Aravamudan
2006-08-15 10:08 ` Pavel Machek [this message]
2006-08-15 22:34 ` Nishanth Aravamudan
2006-08-16 4:19 ` Andrej Zaikin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060815100809.GF7496@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.