From: Andrew Morton <akpm@osdl.org>
To: Andi Kleen <ak@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [2/3] Create call_usermodehelper_pipe()
Date: Tue, 15 Aug 2006 14:22:25 -0700 [thread overview]
Message-ID: <20060815142225.52cc86b3.akpm@osdl.org> (raw)
In-Reply-To: <20060814112731.5A16213BD9@wotan.suse.de>
On Mon, 14 Aug 2006 13:27:31 +0200 (CEST)
Andi Kleen <ak@suse.de> wrote:
> + /* Install input pipe when needed */
> + if (sub_info->stdin) {
> + struct files_struct *f = current->files;
> + struct fdtable *fdt;
> + /* no races because files should be private here */
> + sys_close(0);
> + fd_install(0, sub_info->stdin);
> + spin_lock(&f->file_lock);
> + fdt = files_fdtable(f);
> + FD_SET(0, fdt->open_fds);
> + FD_CLR(0, fdt->close_on_exec);
> + spin_unlock(&f->file_lock);
> + }
This is all going to be run by kernel threads, and all kernel threads share
current->files=&init_files.
So I suspect that if two coredumps happen at the same time bad things will
happen. Like a BUG() in fd_install()?
next prev parent reply other threads:[~2006-08-15 21:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060814 127.183332000@suse.de>
2006-08-14 11:27 ` [PATCH] [1/3] Some cleanup in the pipe code Andi Kleen
2006-08-14 11:27 ` [PATCH] [2/3] Create call_usermodehelper_pipe() Andi Kleen
2006-08-15 21:22 ` Andrew Morton [this message]
2006-08-16 2:13 ` Andrew Morton
2006-08-16 7:22 ` Andi Kleen
2006-08-14 11:27 ` [PATCH] [3/3] Support piping into commands in /proc/sys/kernel/core_pattern Andi Kleen
2006-08-15 0:43 ` Andrew Morton
2006-08-15 6:04 ` Andi Kleen
2006-08-16 8:43 ` Greg KH
2006-08-16 9:18 ` Andi Kleen
2006-08-16 18:10 ` Andrew Morton
2006-08-17 9:46 ` Andi Kleen
2006-08-17 11:27 ` Alan Cox
2006-08-18 5:30 ` Andrew Morton
2006-08-18 8:29 ` Andi Kleen
2006-08-18 12:01 ` Arjan van de Ven
2006-08-18 12:10 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060815142225.52cc86b3.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.