From: Len Brown <len.brown@intel.com>
To: akpm@osdl.org
Cc: linux-acpi@vger.kernel.org, william.morrow@amd.com,
jordan.crouse@amd.com, luming.yu@intel.com
Subject: Re: [patch 13/14] ACPI: Correctly recover from a failed S3 attempt
Date: Wed, 16 Aug 2006 18:00:45 -0400 [thread overview]
Message-ID: <200608161800.45712.len.brown@intel.com> (raw)
In-Reply-To: <200608150537.k7F5bVsB011566@shell0.pdx.osdl.net>
Applied.
This may be the start of unlocking the door to a new class of S3 resume failures.
thanks,
-Len
On Tuesday 15 August 2006 01:37, akpm@osdl.org wrote:
> From: William Morrrow <william.morrow@amd.com>
>
> This was discovered on a broken BIOS that simply returned from its suspend
> procedure, appearing to the OS as a failed S3 attempt.
>
> It is possible to invoke the protected mode register restore routine (which
> would normally restore the sysenter registers) when the bios returns from
> S3. This has no effect on a correctly running system and repairs the
> damage from broken BIOS.
>
> Signed-off-by: William Morrow <william.morrow@amd.com>
> Signed-off-by: Jordan Crouse <jordan.crouse@amd.com>
> Cc: "Yu, Luming" <luming.yu@intel.com>
> Cc: "Brown, Len" <len.brown@intel.com>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
> ---
>
> arch/i386/kernel/acpi/wakeup.S | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff -puN arch/i386/kernel/acpi/wakeup.S~acpi-correctly-recover-from-a-failed-s3-attempt arch/i386/kernel/acpi/wakeup.S
> --- a/arch/i386/kernel/acpi/wakeup.S~acpi-correctly-recover-from-a-failed-s3-attempt
> +++ a/arch/i386/kernel/acpi/wakeup.S
> @@ -292,7 +292,10 @@ ENTRY(do_suspend_lowlevel)
> pushl $3
> call acpi_enter_sleep_state
> addl $4, %esp
> - ret
> +
> +# In case of S3 failure, we'll emerge here. Jump
> +# to ret_point to recover
> + jmp ret_point
> .p2align 4,,7
> ret_point:
> call restore_registers
> _
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2006-08-16 21:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-15 5:37 [patch 13/14] ACPI: Correctly recover from a failed S3 attempt akpm
2006-08-16 4:27 ` Len Brown
2006-08-16 17:58 ` William Morrow
2006-08-16 21:55 ` Len Brown
2006-08-16 22:00 ` Len Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608161800.45712.len.brown@intel.com \
--to=len.brown@intel.com \
--cc=akpm@osdl.org \
--cc=jordan.crouse@amd.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=luming.yu@intel.com \
--cc=william.morrow@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.