All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, Linux PM <linux-pm@osdl.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [linux-pm] [RFC][PATCH 3/3] PM: Remove PM_TRACE from Kconfig
Date: Thu, 17 Aug 2006 04:52:50 -0700	[thread overview]
Message-ID: <20060817115250.GA6843@kroah.com> (raw)
In-Reply-To: <20060817091238.GA17899@elf.ucw.cz>

On Thu, Aug 17, 2006 at 11:12:38AM +0200, Pavel Machek wrote:
> Hi!
> 
> > > Remove the CONFIG_PM_TRACE option, which is dangerous and should only be used
> > > by people who know exactly what they are doing, from Kconfig.
> > 
> > No, don't remove this, that's not acceptable at all.  This is useful for
> > others (and one specifically who will be pissed to see this removed...)
> 
> Yep, while it breaks suspend for every pool soul that enables it by
> mistake. (And in hard-to-debug way, too).
> 
> This option has EXACTLY ONE USER... or more precisely used to have one
> user when he was debugging his mac mini...

I tried it out for a bit when having problems with resume, which I have
yet to resolve properly, so I'll need it again when I get the chance.

And you go tell that "ONE USER" that you disabled his feature :)

thanks,

greg k-h

  reply	other threads:[~2006-08-17 11:52 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-15 13:09 [RFC][PATCH] PM: Use suspend_console in swsusp and make it configureable Rafael J. Wysocki
2006-08-16 10:41 ` Pavel Machek
2006-08-16 11:04   ` Rafael J. Wysocki
2006-08-16 11:04     ` Rafael J. Wysocki
2006-08-16 11:06     ` [RFC][PATCH 1/3] swsusp: Use suspend_console Rafael J. Wysocki
2006-08-16 11:09     ` [RFC][PATCH 2/3] PM: Make console suspending configureable Rafael J. Wysocki
2006-08-16 11:09       ` Rafael J. Wysocki
2006-09-04  9:08       ` Stefan Seyfried
2006-09-04 11:03         ` Rafael J. Wysocki
2006-09-04 11:02           ` Pavel Machek
2006-09-04 21:27             ` Laurent Riffard
2006-08-16 11:14     ` [RFC][PATCH 3/3] PM: Remove PM_TRACE from Kconfig Rafael J. Wysocki
2006-08-16 11:14       ` Rafael J. Wysocki
2006-08-17  4:40       ` Greg KH
2006-08-17  4:40         ` [linux-pm] " Greg KH
2006-08-17  5:24         ` Rafael J. Wysocki
2006-08-17  5:24           ` [linux-pm] " Rafael J. Wysocki
2006-08-17  9:12         ` Pavel Machek
2006-08-17 11:52           ` Greg KH [this message]
2006-08-16 11:37     ` [RFC][PATCH] PM: Use suspend_console in swsusp and make it configureable Pavel Machek
2006-08-16 12:34   ` Nigel Cunningham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060817115250.GA6843@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@osdl.org \
    --cc=pavel@ucw.cz \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.