All of lore.kernel.org
 help / color / mirror / Atom feed
From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] [RFC PATCH 2.6.18-rc4-mm1] hwmon: unchecked return
Date: Fri, 18 Aug 2006 09:18:06 +0000	[thread overview]
Message-ID: <20060818111806.abab2f06.khali@linux-fr.org> (raw)
In-Reply-To: <20060814020407.GA3327@jupiter.solarsys.private>

Hi David,

> > That's not enough, unfortunately. In case of error you must unregister
> > the driver before returning. I also think we should print some message
> > on error. Care to send an updated patch?
> 
> Updated patch attached. I have tested it on my machine and everything
> is working, but if other hwmon drivers use this, can they apply the
> patch on their machine and see if the modules fail to load?

Thanks for the update. I tested this with the it87 driver and it worked
as designed, preventing the driver to load if an error occurs.

Unfortunately you forgot to sign your patch. Can you please resend the
patch with the proper Signed-off-by line? While you're there please
also fix the indentation of the "return" line, which isn't correct.

-- 
Jean Delvare


  parent reply	other threads:[~2006-08-18  9:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-14  2:04 [lm-sensors] [RFC PATCH 2.6.18-rc4-mm1] hwmon: unchecked return Mark M. Hoffman
2006-08-14 13:02 ` Jean Delvare
2006-08-15  0:09 ` David Hubbard
2006-08-15  3:14 ` Mark M. Hoffman
2006-08-15  3:17 ` Mark M. Hoffman
2006-08-15  7:37 ` Jean Delvare
2006-08-15  8:01 ` Jean Delvare
2006-08-16 22:00 ` David Hubbard
2006-08-18  9:18 ` Jean Delvare [this message]
2006-08-20  2:15 ` David Hubbard
2006-08-20 12:23 ` Jean Delvare
2006-08-20 21:23 ` David Hubbard
2006-08-21  8:15 ` Jean Delvare
2006-08-22  5:21 ` David Hubbard
2006-08-23  6:50 ` Jean Delvare
2006-08-28  2:07 ` David Hubbard
2006-08-30  7:10 ` Jean Delvare
2006-09-01 10:21 ` Jean Delvare
2006-09-01 18:20 ` David Hubbard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060818111806.abab2f06.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.