From: "Ed L. Cashin" <ecashin@coraid.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, Greg K-H <greg@kroah.com>
Subject: Re: [PATCH 2.6.18-rc4] aoe [07/13]: jumbo frame support 2 of 2
Date: Fri, 18 Aug 2006 19:04:58 -0400 [thread overview]
Message-ID: <20060818230457.GT29988@coraid.com> (raw)
In-Reply-To: <1155941912.31543.21.camel@localhost.localdomain>
On Fri, Aug 18, 2006 at 11:58:32PM +0100, Alan Cox wrote:
> Ar Gwe, 2006-08-18 am 13:39 -0400, ysgrifennodd Ed L. Cashin:
...
> > @@ -28,7 +28,7 @@ new_skb(ulong len)
> > skb->protocol = __constant_htons(ETH_P_AOE);
> > skb->priority = 0;
> > skb_put(skb, len);
> > - memset(skb->head, 0, len);
> > + memset(skb->head, 0, ETH_ZLEN);
>
> You realise the tail of a short packet is cleared by the network drivers
> either in software or hardware ?
Yes, I think that the patch author is used to doing ETH_ZLEN because
of a bug in the e1000 driver where the short packets weren't getting
padded. I don't think I ever heard of a resolution to that issue, but
I could change it back to "len" here.
--
Ed L Cashin <ecashin@coraid.com>
next prev parent reply other threads:[~2006-08-18 23:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1GE8K3-0008Jn-00@kokone.coraid.com>
2006-08-18 17:38 ` [PATCH 2.6.18-rc4] aoe [02/13]: update copyright date Ed L. Cashin
2006-08-18 22:54 ` Alan Cox
2006-08-18 17:39 ` [PATCH 2.6.18-rc4] aoe [03/13]: remove unused NARGS enum Ed L. Cashin
2006-08-18 22:54 ` Alan Cox
2006-08-18 17:39 ` [PATCH 2.6.18-rc4] aoe [04/13]: zero copy write 1 of 2 Ed L. Cashin
2006-08-19 10:18 ` Alan Cox
2006-08-22 21:21 ` Ed L. Cashin
2006-08-23 15:03 ` Alan Cox
2006-08-18 17:39 ` [PATCH 2.6.18-rc4] aoe [05/13]: jumbo frame support " Ed L. Cashin
2006-08-18 22:56 ` Alan Cox
2006-08-18 17:39 ` [PATCH 2.6.18-rc4] aoe [06/13]: clean up printks via macros Ed L. Cashin
2006-08-18 19:29 ` Arnd Bergmann
2006-08-18 22:23 ` Ed L. Cashin
2006-08-18 22:57 ` Alan Cox
2006-08-18 17:39 ` [PATCH 2.6.18-rc4] aoe [07/13]: jumbo frame support 2 of 2 Ed L. Cashin
2006-08-18 22:58 ` Alan Cox
2006-08-18 23:04 ` Ed L. Cashin [this message]
2006-08-19 0:08 ` Alan Cox
2006-08-18 17:39 ` [PATCH 2.6.18-rc4] aoe [08/13]: improve retransmission heuristics Ed L. Cashin
2006-08-18 23:02 ` Alan Cox
2006-08-18 17:39 ` [PATCH 2.6.18-rc4] aoe [09/13]: zero copy write 2 of 2 Ed L. Cashin
2006-08-18 17:39 ` [PATCH 2.6.18-rc4] aoe [10/13]: module parameter for device timeout Ed L. Cashin
2006-08-18 23:03 ` Alan Cox
2006-08-18 23:10 ` Ed L. Cashin
2006-08-19 0:09 ` Alan Cox
2006-08-21 22:45 ` Ed L. Cashin
2006-08-18 17:40 ` [PATCH 2.6.18-rc4] aoe [11/13]: use bio->bi_idx Ed L. Cashin
2006-08-18 17:40 ` [PATCH 2.6.18-rc4] aoe [12/13]: remove sysfs comment Ed L. Cashin
2006-08-18 17:40 ` [PATCH 2.6.18-rc4] aoe [13/13]: update driver version Ed L. Cashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060818230457.GT29988@coraid.com \
--to=ecashin@coraid.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.