From: Michael Buesch <mb@bu3sch.de>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Solar Designer <solar@openwall.com>,
Alex Riesen <fork0@users.sourceforge.net>,
Willy Tarreau <wtarreau@hera.kernel.org>,
linux-kernel@vger.kernel.org,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH] set*uid() must not fail-and-return on OOM/rlimits
Date: Sun, 20 Aug 2006 18:47:05 +0200 [thread overview]
Message-ID: <200608201847.05707.mb@bu3sch.de> (raw)
In-Reply-To: <44E88DC3.7000708@redhat.com>
On Sunday 20 August 2006 18:28, Ulrich Drepper wrote:
> Arjan van de Ven wrote:
> > sounds like a good argument to get the setuid functions marked
> > __must_check in glibc...
>
> There are too many false positives. E.g., in a SUID binaries switching
> back from a non-root UID to root will not fail. Very common.
Well, I would say it clearly depends on the actual kernel
implementation if that can fail or not.
So userspace should really always check.
--
Greetings Michael.
next prev parent reply other threads:[~2006-08-20 16:47 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-20 0:38 [PATCH] set*uid() must not fail-and-return on OOM/rlimits Solar Designer
2006-08-20 7:52 ` Kari Hurtta
2006-08-20 18:10 ` Alan Cox
2006-08-21 5:05 ` Kari Hurtta
2006-08-20 8:26 ` Willy Tarreau
2006-08-20 15:25 ` Solar Designer
2006-08-20 10:07 ` Alex Riesen
2006-08-20 15:30 ` Solar Designer
2006-08-20 15:53 ` Arjan van de Ven
2006-08-20 16:17 ` Willy Tarreau
2006-08-20 16:28 ` Ulrich Drepper
2006-08-20 16:45 ` Arjan van de Ven
2006-08-20 16:47 ` Michael Buesch [this message]
2006-08-20 16:48 ` Solar Designer
2006-08-20 18:03 ` Alan Cox
2006-08-20 18:10 ` Willy Tarreau
2006-08-20 18:36 ` Alan Cox
2006-08-20 18:21 ` Willy Tarreau
2006-08-20 18:52 ` Alan Cox
2006-08-20 19:01 ` Willy Tarreau
2006-08-20 19:33 ` Alan Cox
2006-08-20 19:17 ` Willy Tarreau
2006-08-20 16:04 ` Florian Weimer
2006-08-20 16:25 ` Solar Designer
2006-08-20 18:14 ` Alan Cox
2006-08-20 22:12 ` Solar Designer
2006-08-20 22:51 ` Alan Cox
2006-08-20 22:58 ` Solar Designer
2006-08-20 23:00 ` Alan Cox
2006-08-21 0:23 ` Peter Williams
2006-08-21 0:45 ` Solar Designer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608201847.05707.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=arjan@infradead.org \
--cc=drepper@redhat.com \
--cc=fork0@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=solar@openwall.com \
--cc=wtarreau@hera.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.