All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: "Björn Steinbrink" <B.Steinbrink@gmx.de>
Cc: Arjan van de Ven <arjan@infradead.org>,
	Chase Venters <chase.venters@clientec.com>,
	Andrew Morton <akpm@osdl.org>,
	Russell King <rmk+lkml@arm.linux.org.uk>,
	rusty@rustcorp.com.au, linux-kernel@vger.kernel.org,
	linux-arch@vger.kernel.org
Subject: Re: [PATCH] introduce kernel_execve function to replace __KERNEL_SYSCALLS__
Date: Sun, 20 Aug 2006 22:33:31 +0200	[thread overview]
Message-ID: <200608202233.33464.arnd@arndb.de> (raw)
In-Reply-To: <20060820201118.GC11843@atjola.homenet>

On Sunday 20 August 2006 22:11, Björn Steinbrink wrote:
> Only one in unistd.h, but throughout the kernel there are quite a few
> unless I'm missing something here:
> doener@atjola:~/src/kernel/linux-2.6$ grep \ _syscall * -R | \
> > grep -v define\\\|undef\\\|clobber | wc -l
> 116

there are only a few direct calls that managed to sneak in after we removed
them all some time ago:

| arch/sh64/kernel/process.c:     _syscall0(int, getpid)
| arch/sh64/kernel/process.c:     _syscall1(int, getpgid, int, pid)
| arch/sh64/kernel/process.c:static __inline__ _syscall2(int,clone,unsigned long,flags,unsigned long,newsp)
| arch/sh64/kernel/process.c:static __inline__ _syscall1(int,exit,int,ret)

These should be replaced with calls to sys_*, or whatever the other
architectures do in order to implement the respective functions.

| arch/um/os-Linux/sys-i386/tls.c:static _syscall1(int, get_thread_area, user_desc_t *, u_info);
| arch/um/os-Linux/process.c:inline _syscall0(pid_t, getpid)
| arch/um/os-Linux/tls.c:static _syscall1(int, get_thread_area, user_desc_t *, u_info);
| arch/um/os-Linux/tls.c:static _syscall1(int, set_thread_area, user_desc_t *, u_info);
| arch/um/sys-i386/unmap.c:static inline _syscall2(int,munmap,void *,start,size_t,len)
| arch/um/sys-i386/unmap.c:static inline _syscall6(void *,mmap2,void *,addr,size_t,len,int,prot,int,flags,int,fd,off_t,offset)
| arch/um/sys-x86_64/unmap.c:static inline _syscall2(int,munmap,void *,start,size_t,len)
| arch/um/sys-x86_64/unmap.c:static inline _syscall6(void *,mmap,void *,addr,size_t,len,int,prot,int,flags,int,fd,off_t,offset)

UML is special, there may be a good reason to use them, if they are not
actually kernel syscalls, but instead calls to the host OS.

	Arnd <><

  parent reply	other threads:[~2006-08-20 20:33 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-19  7:30 [PATCH] Return real errno from execve in ____call_usermodehelper Björn Steinbrink
2006-08-19  8:14 ` Andrew Morton
2006-08-19  8:42   ` Russell King
2006-08-20 13:01     ` Arnd Bergmann
2006-08-20 13:47       ` Björn Steinbrink
2006-08-20 17:13         ` [PATCH] introduce kernel_execve function to replace __KERNEL_SYSCALLS__ Arnd Bergmann
2006-08-20 17:36           ` Chase Venters
2006-08-20 18:25             ` Andrew Morton
2006-08-20 18:32               ` Chase Venters
2006-08-20 19:45                 ` Björn Steinbrink
2006-08-20 19:50                   ` Arjan van de Ven
2006-08-20 20:11                     ` Björn Steinbrink
2006-08-20 20:20                       ` Arjan van de Ven
2006-08-20 20:36                         ` Björn Steinbrink
2006-08-20 20:40                           ` Arjan van de Ven
2006-08-21  1:55                           ` Jeff Dike
2006-08-20 20:33                       ` Arnd Bergmann [this message]
2006-08-20 19:31             ` Arnd Bergmann
2006-08-21  0:36           ` Paul Mackerras
2006-08-21 15:12             ` Arnd Bergmann
2006-08-21 15:17               ` Russell King
2006-08-22  7:29               ` Benjamin Herrenschmidt
2006-08-22  8:00                 ` Björn Steinbrink
2006-08-22 10:06                   ` Arnd Bergmann
2006-08-22 13:39                     ` Jeff Dike
2006-08-22 15:13                       ` Arnd Bergmann
2006-08-22 15:37                         ` Jeff Dike

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200608202233.33464.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=B.Steinbrink@gmx.de \
    --cc=akpm@osdl.org \
    --cc=arjan@infradead.org \
    --cc=chase.venters@clientec.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk+lkml@arm.linux.org.uk \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.