All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Jackson <pj@sgi.com>
To: Nathan Lynch <ntl@pobox.com>
Cc: anton@samba.org, simon.derr@bull.net,
	linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH] cpuset code prevents binding tasks to new cpus
Date: Mon, 21 Aug 2006 16:04:54 -0700	[thread overview]
Message-ID: <20060821160454.9e44427b.pj@sgi.com> (raw)
In-Reply-To: <20060821204251.GB9828@localdomain>

Nathan wrote:
> -	top_cpuset.cpus_allowed = cpu_online_map;
> +	top_cpuset.cpus_allowed = cpu_possible_map;

NAQ

While this seems sensible on systems not using cpusets (but still using
kernels configured for cpusets), it is surprising on systems using
cpusets, on which one expects the cpuset that a task is in to reflect
the cpus that a task is allowed to use.

A long time ago, this code actually had cpu_possible_map here, not
cpu_online_map.  That was changed, in the patch:

  http://lkml.org/lkml/2004/9/12/104
  [Patch] cpusets interoperate with hotplug online maps

Lets discuss this further.  See further my previous reply to Anton.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.925.600.0401

  reply	other threads:[~2006-08-21 23:05 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-21 13:27 cpusets not cpu hotplug aware Anton Blanchard
2006-08-21 13:54 ` Simon Derr
2006-08-21 17:43 ` Paul Jackson
2006-08-21 19:21   ` Anton Blanchard
2006-08-21 20:42     ` [PATCH] cpuset code prevents binding tasks to new cpus Nathan Lynch
2006-08-21 23:04       ` Paul Jackson [this message]
2006-08-21 23:27         ` Nathan Lynch
2006-08-22  4:42           ` Paul Jackson
2006-08-22  5:07             ` Andrew Morton
2006-08-21 21:01     ` cpusets not cpu hotplug aware Paul Jackson
2006-08-22  4:51       ` Andrew Morton
2006-08-22  5:04         ` Nathan Lynch
2006-08-22  5:11           ` Andrew Morton
2006-08-22  5:14           ` Paul Jackson
2006-08-23 22:11             ` Nathan Lynch
2006-08-23 22:39               ` Paul Jackson
2006-08-23 23:39                 ` Nathan Lynch
2006-08-24  2:19                   ` Paul Jackson
2006-08-23 23:49               ` Nathan Lynch
2006-08-24  0:12                 ` Andrew Morton
2006-08-24  0:48                   ` [PATCH] cpuset code prevents binding tasks to new cpus Nathan Lynch
2006-08-24  2:54                   ` cpusets not cpu hotplug aware Paul Jackson
2006-08-22  5:06         ` Paul Jackson
2006-08-22  5:14           ` Andrew Morton
2006-08-22  5:21             ` Paul Jackson
2006-08-23 14:58             ` Anton Blanchard
2006-08-23 18:59               ` Paul Jackson
2006-08-23 19:08               ` Paul Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060821160454.9e44427b.pj@sgi.com \
    --to=pj@sgi.com \
    --cc=akpm@osdl.org \
    --cc=anton@samba.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ntl@pobox.com \
    --cc=simon.derr@bull.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.