From: Adrian Bunk <bunk@stusta.de>
To: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: [RFC: 2.6 patch] build sound/sound_firmware.c only for OSS
Date: Tue, 22 Aug 2006 16:46:20 +0200 [thread overview]
Message-ID: <20060822144620.GY11651@stusta.de> (raw)
All sound/sound_firmware.c contains is mod_firmware_load() that is a
legacy API only used by some OSS drivers.
This patch builds it into an own sound_firmware module that is only
built depending on CONFIG_SOUND_PRIME making the kernel slightly smaller
for ALSA users.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
sound/Makefile | 3 ++-
sound/sound_core.c | 4 ----
sound/sound_firmware.c | 3 +++
3 files changed, 5 insertions(+), 5 deletions(-)
--- linux-2.6.18-rc4-mm2/sound/Makefile.old 2006-08-22 00:07:41.000000000 +0200
+++ linux-2.6.18-rc4-mm2/sound/Makefile 2006-08-22 00:10:41.000000000 +0200
@@ -2,6 +2,7 @@
#
obj-$(CONFIG_SOUND) += soundcore.o
+obj-$(CONFIG_SOUND_PRIME) += sound_firmware.o
obj-$(CONFIG_SOUND_PRIME) += oss/
obj-$(CONFIG_DMASOUND) += oss/
obj-$(CONFIG_SND) += core/ i2c/ drivers/ isa/ pci/ ppc/ arm/ synth/ usb/ sparc/ parisc/ pcmcia/ mips/
@@ -11,4 +12,4 @@
obj-y += last.o
endif
-soundcore-objs := sound_core.o sound_firmware.o
+soundcore-objs := sound_core.o
--- linux-2.6.18-rc4-mm2/sound/sound_core.c.old 2006-08-22 00:09:13.000000000 +0200
+++ linux-2.6.18-rc4-mm2/sound/sound_core.c 2006-08-22 00:12:10.000000000 +0200
@@ -517,10 +517,6 @@
return -ENODEV;
}
-extern int mod_firmware_load(const char *, char **);
-EXPORT_SYMBOL(mod_firmware_load);
-
-
MODULE_DESCRIPTION("Core sound module");
MODULE_AUTHOR("Alan Cox");
MODULE_LICENSE("GPL");
--- linux-2.6.18-rc4-mm2/sound/sound_firmware.c.old 2006-08-22 00:10:53.000000000 +0200
+++ linux-2.6.18-rc4-mm2/sound/sound_firmware.c 2006-08-22 00:26:03.000000000 +0200
@@ -4,6 +4,7 @@
#include <linux/mm.h>
#include <linux/slab.h>
#include <asm/uaccess.h>
+#include "oss/sound_firmware.h"
static int do_mod_firmware_load(const char *fn, char **fp)
{
@@ -73,4 +74,6 @@
set_fs(fs);
return r;
}
+EXPORT_SYMBOL(mod_firmware_load);
+MODULE_LICENSE("GPL");
next reply other threads:[~2006-08-22 14:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-22 14:46 Adrian Bunk [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-09-04 11:41 [RFC: 2.6 patch] build sound/sound_firmware.c only for OSS Adrian Bunk
2006-09-04 11:41 ` Adrian Bunk
2006-09-04 12:11 ` Alan Cox
2006-09-04 12:11 ` Alan Cox
2006-09-05 12:26 ` Takashi Iwai
2006-08-22 14:46 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060822144620.GY11651@stusta.de \
--to=bunk@stusta.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.