All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Pearce <spearce@spearce.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [RFC] adding support for md5
Date: Wed, 23 Aug 2006 00:14:53 -0400	[thread overview]
Message-ID: <20060823041453.GA25796@spearce.org> (raw)
In-Reply-To: <7vr6z9s376.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> wrote:
> I personally am not interested in making this configurable at
> all.  The hashcmp() change on the other hand to abstract out 20
> was a good preparation, if we ever want to switch to longer
> hashes we would know where to look.

What about all of those memcpy(a, b, 20)'s?  :-)

I can see us wanting to support say SHA-128 or SHA-256 in a few
years.  Especially as processors get faster and better attacks are
developed against SHA-1 such that its no longer really the best
trade-off hash function available.

-- 
Shawn.

  reply	other threads:[~2006-08-23  4:15 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-18  6:01 [RFC] adding support for md5 David Rientjes
2006-08-18  9:59 ` Nguyễn Thái Ngọc Duy
2006-08-18 10:21 ` Johannes Schindelin
2006-08-18 12:31   ` Petr Baudis
2006-08-18 20:35   ` David Rientjes
2006-08-18 10:52 ` Trekie
2006-08-18 10:56   ` Johannes Schindelin
2006-08-18 11:27     ` Trekie
2006-08-18 11:37       ` Johannes Schindelin
2006-08-18 21:52 ` Jon Smirl
2006-08-19  2:35   ` Johannes Schindelin
2006-08-19 20:50 ` Linus Torvalds
2006-08-21 20:44   ` Chris Wedgwood
2006-08-22  6:18     ` Junio C Hamano
2006-08-23  4:14       ` Shawn Pearce [this message]
2006-08-23  4:46         ` Junio C Hamano
2006-08-23  6:49           ` Shawn Pearce
2006-08-24  7:36             ` Junio C Hamano
2006-08-24  8:08               ` Shawn Pearce
2006-08-24 10:34                 ` Junio C Hamano
  -- strict thread matches above, loose matches on Subject: below --
2006-08-19  3:19 linux
2006-08-19 22:30 ` Petr Baudis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060823041453.GA25796@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.