From: Valerie Henson <val_henson@linux.intel.com>
To: Pozsar Balazs <pozsy@uhulinux.hu>
Cc: Jeff Garzik <jgarzik@pobox.com>,
Prakash Punnoor <prakash@punnoor.de>, Jiri Benc <jbenc@suse.cz>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC/PATCH] Fixes for ULi5261 (tulip driver)
Date: Wed, 23 Aug 2006 09:56:14 -0700 [thread overview]
Message-ID: <20060823165614.GF10658@goober> (raw)
In-Reply-To: <20060823091919.GA5806@ojjektum.uhulinux.hu>
On Wed, Aug 23, 2006 at 11:19:19AM +0200, Pozsar Balazs wrote:
>
> The funny thing is that it seems the _first_ phy_read call always
> returns only when the 0x8000 bit is gone (I got this while loop from the
> xircom_tulip driver).
That's pretty much the answer I was suspecting. Sounds like the read
is doing some sort of flush. Unfortunately I can't find any docs, so
I'd rather keep things as close to the old code as possible to avoid
breaking other cards. Does something like this also work?
udelay(500); /* Paranoia - phy_read() may be sufficient */
if (phy_read(db->ioaddr, db->phy_addr, 0, db->chip_id) & 0x8000)
printk("some useful error message");
-VAL
next prev parent reply other threads:[~2006-08-23 16:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-27 10:49 [RFC/PATCH] Fixes for ULi5261 (tulip driver) Jiri Benc
2006-08-15 9:25 ` Pozsar Balazs
2006-08-16 17:11 ` Jiri Benc
2006-08-16 17:43 ` Pozsar Balazs
2006-08-16 18:02 ` Prakash Punnoor
2006-08-16 19:53 ` Pozsar Balazs
2006-08-19 0:16 ` Valerie Henson
2006-08-19 6:15 ` Pozsar Balazs
2006-08-19 14:36 ` Jeff Garzik
2006-08-21 9:03 ` Pozsar Balazs
2006-08-23 6:28 ` Valerie Henson
2006-08-23 9:19 ` Pozsar Balazs
2006-08-23 16:56 ` Valerie Henson [this message]
2006-08-23 23:27 ` Nigel Cunningham
2006-08-24 0:14 ` Nigel Cunningham
2006-08-23 16:59 ` Prakash Punnoor
2006-08-24 17:23 ` Valerie Henson
2006-08-28 11:40 ` Prakash Punnoor
-- strict thread matches above, loose matches on Subject: below --
2005-04-29 9:42 Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060823165614.GF10658@goober \
--to=val_henson@linux.intel.com \
--cc=jbenc@suse.cz \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pozsy@uhulinux.hu \
--cc=prakash@punnoor.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.