From: Frederik Deweerdt <deweerdt@free.fr>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] all files: init, cleanup to module init/exit
Date: Wed, 23 Aug 2006 22:44:28 +0000 [thread overview]
Message-ID: <20060824003117.GB1543@slug> (raw)
In-Reply-To: <d16b1c80608220613y461197a9ye0c53b51823d8f0c@mail.gmail.com>
On Thu, Aug 24, 2006 at 01:58:41AM +0530, Raseel Bhagat wrote:
> Hi ,
>
> On 8/23/06, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> > True, but that isn't the worst sin of this patch. What to do with
> >
> > #ifdef MODULE
> >
> > sprinkled all over touched files and left?
> >
> I don't understand how is that a problem. ?
> There are appropriate #endif s aren't there ?
Yes there are, but if you're using module_init, the compiler will do
the right thing:
- if MODULE is defined, the function will be called at load time
- if not, do_initcalls will call the init function at boot time
Regards,
Frederik
>
>
> --
> Raseel.
> http://osd.byethost8.com
> http://raseel.livejournal.com
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.osdl.org
> https://lists.osdl.org/mailman/listinfo/kernel-janitors
>
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2006-08-23 22:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-22 13:25 [KJ] [PATCH] all files: init, cleanup to module init/exit Shakthi Kannan
2006-08-23 7:57 ` Raseel Bhagat
2006-08-23 16:24 ` Alexey Dobriyan
2006-08-23 20:40 ` Raseel Bhagat
2006-08-23 22:44 ` Frederik Deweerdt [this message]
2006-08-24 4:38 ` Raseel Bhagat
2006-08-24 8:01 ` Frederik Deweerdt
2006-08-25 8:09 ` Shakthi Kannan
2006-08-25 8:33 ` Raseel Bhagat
2006-08-27 12:30 ` Domen Puncer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060824003117.GB1543@slug \
--to=deweerdt@free.fr \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.