All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Jackson <pj@sgi.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Jan Beulich <jbeulich@novell.com>, Paul Jackson <pj@sgi.com>,
	linux-kernel@vger.kernel.org, Andi Kleen <ak@suse.de>
Subject: [PATCH] x86_64: mm fix x86 cpuid keys used in alternative_smp fix
Date: Thu, 24 Aug 2006 03:58:46 -0700	[thread overview]
Message-ID: <20060824105846.23508.59971.sendpatchset@sam.engr.sgi.com> (raw)

From: Paul Jackson <pj@sgi.com>

The x86_64 crosstool build was failing due to:

  kernel/built-in.o(.smp_altinstructions+0x58): \
    include/asm/spinlock.h:54: undefined reference to `X86_FEATURE_UP'

This reference to X86_FEATURE_UP was added to the definition of
the alternative_smp() macro in alternative.h by the patch:
  x86_64-mm-fix-x86-cpuid-keys-used-in-alternative_smp

The alternative_smp() macro is used in spinlock.h.

The definition of X86_FEATURE_UP is in asm-x86_64/cpufeature.h.
If this is included in alternative.h, then the build succeeds.

Signed-off-by: Paul Jackson <pj@sgi.com>

---

 include/asm-x86_64/alternative.h |    1 +
 1 files changed, 1 insertion(+)

--- 2.6.18-rc4-mm2.orig/include/asm-x86_64/alternative.h	2006-08-24 03:37:22.000000000 -0700
+++ 2.6.18-rc4-mm2/include/asm-x86_64/alternative.h	2006-08-24 03:38:09.000000000 -0700
@@ -4,6 +4,7 @@
 #ifdef __KERNEL__
 
 #include <linux/types.h>
+#include <asm/cpufeature.h>
 
 struct alt_instr {
 	u8 *instr; 		/* original instruction */

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.925.600.0401

             reply	other threads:[~2006-08-24 10:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-24 10:58 Paul Jackson [this message]
2006-08-24 11:33 ` [PATCH] x86_64: mm fix x86 cpuid keys used in alternative_smp fix Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060824105846.23508.59971.sendpatchset@sam.engr.sgi.com \
    --to=pj@sgi.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=jbeulich@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.