From: Thomas Graf <tgraf@suug.ch>
To: Michael Buesch <mb@bu3sch.de>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Jiri Benc <jbenc@suse.cz>,
"John W. Linville" <linville@tuxdriver.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: [RFC] make d80211 use nl80211
Date: Thu, 24 Aug 2006 19:36:59 +0200 [thread overview]
Message-ID: <20060824173659.GO3470@postel.suug.ch> (raw)
In-Reply-To: <200608241909.35065.mb@bu3sch.de>
* Michael Buesch <mb@bu3sch.de> 2006-08-24 19:09
> On Thursday 24 August 2006 18:07, Johannes Berg wrote:
> > + pkt = alloc_skb(framelen, GFP_KERNEL);
>
> if (!pkt)
> return -ENOMEM;
>
> > + pktdata = skb_put(pkt, framelen);
> > + memcpy(pktdata, frame, framelen);
>
> having two variables with almost the same name seems
> confusing to me. What about removing void *pktdata; and
> doing the following instead of the two lines above?
>
> memcpy(skb_put(pkt, framelen), frame, framelen);
>
> That is also how it's done in lots of other networking code.
You might want to use 'skb' instead of 'pkt', everyone
has got used to it.
next prev parent reply other threads:[~2006-08-24 17:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-22 13:53 [RFC] make d80211 use nl80211 Johannes Berg
2006-08-24 14:05 ` Jiri Benc
2006-08-24 16:07 ` Johannes Berg
2006-08-24 17:09 ` Michael Buesch
2006-08-24 17:36 ` Thomas Graf [this message]
2006-08-25 11:02 ` [RFC take3] " Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060824173659.GO3470@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=jbenc@suse.cz \
--cc=johannes@sipsolutions.net \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.