From: Arnd Bergmann <arnd@arndb.de>
To: David Hollis <dhollis@davehollis.com>
Cc: dbrownell@users.sourceforge.net, linux-kernel@vger.kernel.org,
linux-usb-devel@lists.sourceforge.net, support@moschip.com,
Michael Helmling <supermihi@web.de>
Subject: [PATCH] mcs7830: fix reception of 1514 byte frames
Date: Sun, 27 Aug 2006 22:41:53 +0200 [thread overview]
Message-ID: <200608272241.54161.arnd@arndb.de> (raw)
In-Reply-To: <200608272241.05026.arnd@arndb.de>
The mcs7830 chip always appends a byte with status information
to an rx frame, so the URB needs to reserve an extra byte.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Index: linux-cg/drivers/usb/net/mcs7830.c
===================================================================
--- linux-cg.orig/drivers/usb/net/mcs7830.c 2006-08-25 21:23:35.000000000 +0200
+++ linux-cg/drivers/usb/net/mcs7830.c 2006-08-25 21:26:02.000000000 +0200
@@ -405,6 +405,9 @@
net->set_multicast_list = mcs7830_set_multicast;
mcs7830_set_multicast(net);
+ /* reserve space for the status byte on rx */
+ dev->rx_urb_size = ETH_FRAME_LEN + 1;
+
dev->mii.mdio_read = mcs7830_mdio_read;
dev->mii.mdio_write = mcs7830_mdio_write;
dev->mii.dev = net;
next prev parent reply other threads:[~2006-08-27 23:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-07 13:00 [PATCH] please review mcs7830 (DeLOCK USB etherner) driver Arnd Bergmann
2006-08-07 14:54 ` David Hollis
2006-08-07 16:11 ` Arnd Bergmann
2006-08-20 20:07 ` [PATCH] driver for mcs7830 (aka DeLOCK) USB ethernet adapter Arnd Bergmann
2006-08-20 20:13 ` [PATCH] usbnet: add a mutex around phy register access Arnd Bergmann
2006-08-21 14:34 ` [PATCH] driver for mcs7830 (aka DeLOCK) USB ethernet adapter David Hollis
2006-08-27 20:41 ` [PATCH] mcs7830: clean up use of kernel constants Arnd Bergmann
2006-08-27 20:41 ` Arnd Bergmann [this message]
2006-09-02 10:33 ` [linux-usb-devel] [PATCH] mcs7830: fix reception of 1514 byte frames David Brownell
2006-09-02 18:29 ` Arnd Bergmann
2006-08-28 19:09 ` [PATCH] mcs7830: clean up use of kernel constants David Hollis
2006-09-02 10:38 ` [linux-usb-devel] [PATCH] driver for mcs7830 (aka DeLOCK) USB ethernet adapter David Brownell
2006-09-02 17:51 ` Arnd Bergmann
2006-09-04 6:40 ` David Brownell
2006-09-07 19:37 ` David Hollis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608272241.54161.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=dbrownell@users.sourceforge.net \
--cc=dhollis@davehollis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=supermihi@web.de \
--cc=support@moschip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.