From: Andi Kleen <ak@suse.de>
To: Gerd Hoffmann <kraxel@suse.de>
Cc: linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [patch] fix up smp alternatives on x86-64
Date: Mon, 28 Aug 2006 11:22:38 +0200 [thread overview]
Message-ID: <200608281122.38829.ak@suse.de> (raw)
In-Reply-To: <44F2B557.6020403@suse.de>
On Monday 28 August 2006 11:20, Gerd Hoffmann wrote:
> Don't use alternative_smp() in for __raw_spin_lock. gcc
> sometimes generates rip-relative addressing, so we can't
> simply copy the instruction to another place.
>
> Replace some leftover "lock;" with LOCK_PREFIX.
>
> Fillup space with 0x90 (nop) instead of 0x42, so
> "objdump -d -j .smp_altinstr_replacement vmlinux" gives more
> readable results.
I already fixed it myself.
ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt/patches/remove-alternative-smp
ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt/patches/i386-remove-alternative-smp
And all the left over lock prefixes are also gone in that tree.
-Andi
prev parent reply other threads:[~2006-08-28 9:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-28 9:20 [patch] fix up smp alternatives on x86-64 Gerd Hoffmann
2006-08-28 9:22 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608281122.38829.ak@suse.de \
--to=ak@suse.de \
--cc=kraxel@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.