From: Alexander Zarochentsev <zam@namesys.com>
To: reiserfs-list@namesys.com
Cc: Brice Arnould <un_brice@vleu.net>
Subject: Re: Possible bug with FIBMAP
Date: Mon, 28 Aug 2006 12:33:47 +0400 [thread overview]
Message-ID: <200608281233.48338.zam@namesys.com> (raw)
In-Reply-To: <200608271057.12684.un_brice@vleu.net>
On 27 August 2006 12:57, Brice Arnould wrote:
> Hi
>
> Two users of a hack I wrote told me that
> http://vleu.net/shake/fb_r4.c (also attached with the mail)
> returned "FIBMAP=-22, FIGETBSZ=4096"
> on some of their files on reiser4 filesystems.
>
> Does this value of "-22" have a special meaning (would be strange),
> or is it a bug in Reiser4 ?
> I can ask them for more details, if you want.
Reiser4: restore FIBMAP ioctl support for packed files
restore FIBMAP ioctl support for packed files,
don't report block numbers for not yet mapped to
disk nodes.
Signed-off-by: Alexander Zarochentsev <zam@namesys.com>
---
fs/reiser4/plugin/item/item.c | 2 +-
fs/reiser4/plugin/item/tail.c | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
--- linux-2.6-git.orig/fs/reiser4/plugin/item/item.c
+++ linux-2.6-git/fs/reiser4/plugin/item/item.c
@@ -614,7 +614,7 @@ item_plugin item_plugins[LAST_ITEM_ID] =
.write = reiser4_write_tail,
.read = reiser4_read_tail,
.readpage = readpage_tail,
- .get_block = NULL,
+ .get_block = get_block_address_tail,
.append_key = append_key_tail,
.init_coord_extension =
init_coord_extension_tail
--- linux-2.6-git.orig/fs/reiser4/plugin/item/tail.c
+++ linux-2.6-git/fs/reiser4/plugin/item/tail.c
@@ -791,6 +791,8 @@ get_block_address_tail(const coord_t * c
assert("nikita-3252", znode_get_level(coord->node) == LEAF_LEVEL);
*block = *znode_get_block(coord->node);
+ if (reiser4_blocknr_is_fake(block))
+ *block = 0;
return 0;
}
next prev parent reply other threads:[~2006-08-28 8:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-27 8:57 Possible bug with FIBMAP Brice Arnould
2006-08-27 19:35 ` Ivan Pulleyn
2006-08-27 19:39 ` Ivan Pulleyn
2006-08-28 6:33 ` Hans Reiser
2006-08-28 8:33 ` Alexander Zarochentsev [this message]
2006-08-29 7:09 ` Brice Arnould
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608281233.48338.zam@namesys.com \
--to=zam@namesys.com \
--cc=reiserfs-list@namesys.com \
--cc=un_brice@vleu.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.