From: Jens Axboe <axboe@kernel.dk>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] exit_io_context: don't disable irqs
Date: Tue, 29 Aug 2006 09:14:29 +0200 [thread overview]
Message-ID: <20060829071429.GQ30609@kernel.dk> (raw)
In-Reply-To: <20060826203142.GA333@oleg>
On Sun, Aug 27 2006, Oleg Nesterov wrote:
> We don't need to disable irqs to clear current->io_context, it is
> protected by ->alloc_lock. Even IF it was possible to submit I/O from
> IRQ on behalf of current this irq_disable() can't help:
> current_io_context() will re-instantiate ->io_context after
> irq_enable().
>
> We don't need task_lock() or local_irq_disable() to clear ioc->task.
> This can't prevent other CPUs from playing with our io_context anyway.
>
> Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2006-08-29 7:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-26 20:31 [PATCH] exit_io_context: don't disable irqs Oleg Nesterov
2006-08-29 7:14 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060829071429.GQ30609@kernel.dk \
--to=axboe@kernel.dk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.