From: Jens Axboe <axboe@kernel.dk>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] sys_ioprio_set: don't disable irqs
Date: Tue, 29 Aug 2006 09:16:30 +0200 [thread overview]
Message-ID: <20060829071630.GR30609@kernel.dk> (raw)
In-Reply-To: <20060826205949.GA1140@oleg>
On Sun, Aug 27 2006, Oleg Nesterov wrote:
> It is not good to disable interrupts while traversing all tasks in the system.
> As I see it, sys_ioprio_get() doesn't need to do it at all, sys_ioprio_set()
> does it for cfq_ioc_set_ioprio(), the latter can disable irqs itself.
>
> Also, add a comment to explain why do we need tasklist_lock.
>
> Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
You should work against the 'block' branch in the block git repo, things
tend to change... I've applied your ioprio.c bit, the other one is not
needed anymore.
--
Jens Axboe
prev parent reply other threads:[~2006-08-29 7:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-26 20:59 [PATCH RESEND] sys_ioprio_set: don't disable irqs Oleg Nesterov
2006-08-29 7:16 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060829071630.GR30609@kernel.dk \
--to=axboe@kernel.dk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.