From: Christoph Hellwig <hch@infradead.org>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] fix scsi_send_eh_cmnd regression
Date: Tue, 29 Aug 2006 13:04:28 +0100 [thread overview]
Message-ID: <20060829120428.GA25359@infradead.org> (raw)
In-Reply-To: <1156575622.2828.4.camel@max>
On Sat, Aug 26, 2006 at 03:00:22AM -0400, Mike Christie wrote:
> The callers of scsi_send_eh_cmnd are setting the cmnd buffer,
> and then scsi_send_eh_cmnd is copying that updated buffer to
> the old_cmnd variable. Then after the command runs, we end up
> copying that old_cmnd var which has the new cmnd to the scsi
> command buffer. When this command gets recent, all types of fun
> things happen like getting TUR or START_STOP commands with
> data and scatterlists.
>
> This patch made against scsi-rc-fixes, has the callers of
> scsi_send_eh_cmnd pass in the command so scsi_send_eh_cmnd
> can do the right thing. This should go into 2.6.18 since this
> fixes a regression added when we removed some of the scsi_cmnd
> fields and replaced them with local variables.
Ok. Thanks a lot for fixing this.
I really wish we had something like a regression test suite to find
things like this..
prev parent reply other threads:[~2006-08-29 12:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-26 7:00 [PATCH] fix scsi_send_eh_cmnd regression Mike Christie
2006-08-29 12:04 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060829120428.GA25359@infradead.org \
--to=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.