From: Stephen Hemminger <shemminger@osdl.org>
To: Martin Josefsson <gandalf@wlug.westbo.se>
Cc: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH 4/6] net neighbour: convert to RCU
Date: Tue, 29 Aug 2006 13:17:44 -0700 [thread overview]
Message-ID: <20060829131744.43a018b0@localhost.localdomain> (raw)
In-Reply-To: <1156876442.25085.2.camel@localhost.localdomain>
On Tue, 29 Aug 2006 20:34:01 +0200
Martin Josefsson <gandalf@wlug.westbo.se> wrote:
> On Tue, 2006-08-29 at 11:22 -0700, Stephen Hemminger wrote:
>
> > > Probably, you should do atomic_inc_and_test() here and restart lookup,
> > > if it fails.
> > >
> > > Alexey
> >
> > atomic_inc_and_test is true iff result is zero, so that won't work.
>
> Wouldn't atomic_inc_not_zero() do what you want?
>
Yes, but that code looks more complex for the common case.
It ends up doing a compare exchange and retrying.
--
Stephen Hemminger <shemminger@osdl.org>
next prev parent reply other threads:[~2006-08-29 20:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-28 23:07 [PATCH 0/6] Lockless neighbour table Stephen Hemminger
2006-08-28 23:07 ` [PATCH 1/6] net neighbor: convert top level list to RCU Stephen Hemminger
2006-08-28 23:07 ` [PATCH 2/6] neighbour: convert neighbour hash table to hlist Stephen Hemminger
2006-08-28 23:07 ` [PATCH 3/6] neighbour: convert pneigh " Stephen Hemminger
2006-08-28 23:07 ` [PATCH 4/6] net neighbour: convert to RCU Stephen Hemminger
2006-08-29 15:28 ` Alexey Kuznetsov
2006-08-29 18:22 ` Stephen Hemminger
2006-08-29 18:34 ` Martin Josefsson
2006-08-29 20:17 ` Stephen Hemminger [this message]
2006-08-29 21:17 ` Alexey Kuznetsov
2006-08-29 21:46 ` Stephen Hemminger
2006-08-29 22:16 ` Alexey Kuznetsov
2006-08-29 23:00 ` Stephen Hemminger
2006-08-29 23:21 ` Alexey Kuznetsov
2006-08-29 23:49 ` Stephen Hemminger
2006-08-30 0:06 ` Alexey Kuznetsov
2006-08-29 23:36 ` Alexey Kuznetsov
2006-08-28 23:07 ` [PATCH 5/6] neighbour: convert lookup to sequence lock Stephen Hemminger
2006-08-28 23:07 ` [PATCH 6/6] neighbour: convert hard header cache to sequence number Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060829131744.43a018b0@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=davem@davemloft.net \
--cc=gandalf@wlug.westbo.se \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.