From: Matthew Wilcox <matthew@wil.cx>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] Fwd: [Patch] Add HZ values and time_after() macros in
Date: Tue, 29 Aug 2006 17:30:58 +0000 [thread overview]
Message-ID: <20060829173058.GE11548@parisc-linux.org> (raw)
In-Reply-To: <82faac5b0608290944o2452a904x4826da8bbd944daa@mail.gmail.com>
On Tue, Aug 29, 2006 at 10:00:08AM -0700, Nishanth Aravamudan wrote:
> Yes, that is true. I support your changes in general, but given that
> HZ\x1000 in original 2.6, I would suggest that 50 jiffies is not the same
> as HZ/2. It should either be HZ/20 or, preferably, msecs_to_jiffies(50).
> If the maintainer then replies saying they had never changed the code
> from 2.4's HZ to 2.6, then we can proceed accordingly and your current
> change is more appropriate, but I wouldn't assume that to be the case.
It's easy enough to look at 2.4:
if(((jiffies - timer)>50)||((dev->ffL.tcq_rd=dev->host_tcq_wr))){
So the patch is a bugfix.
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2006-08-29 17:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-29 16:44 [KJ] Fwd: [Patch] Add HZ values and time_after() macros in iphase.c Darren Jenkins
2006-08-29 17:00 ` [KJ] Fwd: [Patch] Add HZ values and time_after() macros in Nishanth Aravamudan
2006-08-29 17:30 ` Matthew Wilcox [this message]
2006-08-29 17:53 ` Nishanth Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060829173058.GE11548@parisc-linux.org \
--to=matthew@wil.cx \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.