All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aron Griffis <aron@hp.com>
To: Hollis Blanchard <hollisb@us.ibm.com>
Cc: xen-devel <xen-devel@lists.xensource.com>,
	Ian Campbell <Ian.Campbell@xensource.com>
Subject: Re: [patch] fix void* arithmetic
Date: Tue, 29 Aug 2006 16:35:31 -0400	[thread overview]
Message-ID: <20060829203531.GH12590@fc.hp.com> (raw)
In-Reply-To: <1156883088.29858.69.camel@basalt.austin.ibm.com>

Hollis Blanchard wrote:  [Tue Aug 29 2006, 04:24:48PM EDT]
> +#define ELFNOTE_NAME(_n_)   ((void*)((char*)(_n_) + sizeof(*(_n_))))
> +#define ELFNOTE_DESC(_n_)   (((void*)((char*)ELFNOTE_NAME(_n_) + (((_n_)->namesz+3)&~3))))
> +#define ELFNOTE_NEXT(_n_)   (((void*)((char*)ELFNOTE_DESC(_n_) + (((_n_)->descsz+3)&~3))))

Too many parens on the latter two?  I think this is the same:

#define ELFNOTE_NAME(_n_)   ((void*)((char*)(_n_) + sizeof(*(_n_))))
#define ELFNOTE_DESC(_n_)   ((void*)((char*)ELFNOTE_NAME(_n_) + (((_n_)->namesz+3)&~3)))
#define ELFNOTE_NEXT(_n_)   ((void*)((char*)ELFNOTE_DESC(_n_) + (((_n_)->descsz+3)&~3)))

Aron

  reply	other threads:[~2006-08-29 20:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-29 20:24 [patch] fix void* arithmetic Hollis Blanchard
2006-08-29 20:35 ` Aron Griffis [this message]
2006-08-29 21:06 ` Ian Campbell
2006-08-29 21:18   ` Hollis Blanchard
2006-08-29 21:26     ` Jeff Garzik
2006-08-30 16:35     ` Keir Fraser
2006-08-30  8:47 ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060829203531.GH12590@fc.hp.com \
    --to=aron@hp.com \
    --cc=Ian.Campbell@xensource.com \
    --cc=hollisb@us.ibm.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.