From: Andi Kleen <ak@suse.de>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Alon Bar-Lev <alon.barlev@gmail.com>,
Matt Domsch <Matt_Domsch@dell.com>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, johninsd@san.rr.com
Subject: Re: [PATCH] THE LINUX/I386 BOOT PROTOCOL - Breaking the 256 limit (ping)
Date: Wed, 30 Aug 2006 21:06:18 +0200 [thread overview]
Message-ID: <200608302106.18080.ak@suse.de> (raw)
In-Reply-To: <44F5E01C.3010807@zytor.com>
On Wednesday 30 August 2006 20:59, H. Peter Anvin wrote:
> Alon Bar-Lev wrote:
> >
> > This is not entirely true...
> > All architectures sets saved_command_line variable...
> > So I can add __init to the saved_command_line and
> > copy its contents into kmalloced persistence_command_line at
> > main.c.
> >
>
> My opinion is that you should change saved_command_line (which already
> implies a copy) to be the kmalloc'd version and call the fixed-sized
> buffer something else.
It might be safer to rename everything. Then all users could be caught
and audited. This would ensure saved_command_line is not accessed
before the kmalloc'ed copy exists.
Disadvantage: more architectures to change.
-Andi
next prev parent reply other threads:[~2006-08-30 19:06 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-05 13:37 [PATCH][TAKE 4] THE LINUX/I386 BOOT PROTOCOL - Breaking the 256 limit Alon Bar-Lev
2006-05-05 14:09 ` H. Peter Anvin
2006-05-05 14:28 ` Alon Bar-Lev
2006-05-05 14:35 ` H. Peter Anvin
2006-05-05 18:10 ` John Coffman
2006-05-05 18:17 ` H. Peter Anvin
2006-05-05 21:48 ` John Coffman
2006-05-05 21:57 ` H. Peter Anvin
2006-05-06 3:57 ` John Coffman
2006-05-06 5:11 ` H. Peter Anvin
2006-05-06 10:31 ` Alon Bar-Lev
[not found] ` <44AD583B.5040007@gmail.com>
[not found] ` <44AD5BB4.9090005@zytor.com>
[not found] ` <44AD5D47.8010307@gmail.com>
[not found] ` <44AD5FD8.6010307@zytor.com>
[not found] ` <9e0cf0bf0608031436x19262ab0rb2271b52ce75639d@mail.gmail.com>
[not found] ` <44D278D6.2070106@zytor.com>
[not found] ` <9e0cf0bf0608031542q2da20037h828f4b8f0d01c4d5@mail.gmail.com>
[not found] ` <44D27F22.4080205@zytor.com>
2006-08-25 23:57 ` [PATCH] THE LINUX/I386 BOOT PROTOCOL - Breaking the 256 limit (ping) Alon Bar-Lev
2006-08-27 18:28 ` Andi Kleen
2006-08-27 18:50 ` H. Peter Anvin
2006-08-27 19:16 ` Andi Kleen
2006-08-27 19:32 ` H. Peter Anvin
2006-08-27 20:54 ` Andi Kleen
2006-08-27 21:39 ` H. Peter Anvin
2006-08-28 3:28 ` John Coffman
2006-08-28 6:02 ` Alon Bar-Lev
2006-08-28 6:41 ` Alon Bar-Lev
2006-08-28 7:31 ` H. Peter Anvin
2006-08-28 12:19 ` Alon Bar-Lev
2006-08-28 18:28 ` H. Peter Anvin
2006-08-28 18:46 ` Matt Domsch
2006-08-28 19:00 ` H. Peter Anvin
2006-08-28 20:12 ` Matt Domsch
2006-08-28 20:29 ` Alon Bar-Lev
2006-08-28 20:33 ` H. Peter Anvin
2006-08-28 20:43 ` H. Peter Anvin
2006-08-30 16:49 ` Alon Bar-Lev
2006-08-30 16:56 ` Andi Kleen
2006-08-30 17:06 ` Alon Bar-Lev
2006-08-30 17:31 ` Andi Kleen
2006-08-30 17:51 ` Alon Bar-Lev
2006-08-30 18:59 ` H. Peter Anvin
2006-08-30 19:06 ` Andi Kleen [this message]
2006-08-30 19:07 ` H. Peter Anvin
2006-08-30 19:23 ` Alon Bar-Lev
2006-08-30 19:33 ` H. Peter Anvin
2006-08-30 18:58 ` H. Peter Anvin
2006-08-28 19:24 ` Alon Bar-Lev
2006-08-28 20:32 ` H. Peter Anvin
2006-08-29 0:13 ` [PATCH] Fix the EDD code misparsing the command line H. Peter Anvin
2006-08-29 1:24 ` Petr Vandrovec
2006-08-29 1:36 ` H. Peter Anvin
2006-08-29 1:51 ` [PATCH] Fix the EDD code misparsing the command line (rev 2) H. Peter Anvin
2006-08-27 19:59 ` [PATCH] THE LINUX/I386 BOOT PROTOCOL - Breaking the 256 limit (ping) Alon Bar-Lev
2006-05-05 22:02 ` [PATCH][TAKE 4] THE LINUX/I386 BOOT PROTOCOL - Breaking the 256 limit Alon Bar-Lev
[not found] <6OyEf-3Zm-5@gated-at.bofh.it>
[not found] ` <6PCwg-3mz-43@gated-at.bofh.it>
[not found] ` <6PDBU-5Qb-25@gated-at.bofh.it>
[not found] ` <6PDBU-5Qb-23@gated-at.bofh.it>
2006-08-31 17:32 ` [PATCH] THE LINUX/I386 BOOT PROTOCOL - Breaking the 256 limit (ping) Bodo Eggert
2006-08-31 17:40 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608302106.18080.ak@suse.de \
--to=ak@suse.de \
--cc=Matt_Domsch@dell.com \
--cc=akpm@osdl.org \
--cc=alon.barlev@gmail.com \
--cc=hpa@zytor.com \
--cc=johninsd@san.rr.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.