From: Ben Dooks <ben-linux@fluff.org>
To: Dirk Opfer <Dirk@Opfer-Online.de>
Cc: netdev@vger.kernel.org, Ben Dooks <ben@simtec.co.uk>,
Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: [PATCH] Fix dm9000 release_resource
Date: Thu, 31 Aug 2006 10:39:40 +0100 [thread overview]
Message-ID: <20060831093940.GA3623@home.fluff.org> (raw)
In-Reply-To: <0ML25U-1GIK892FsT-0007pS@mrelayeu.kundenserver.de>
On Wed, Aug 30, 2006 at 09:04:45AM +0200, Dirk Opfer wrote:
> dm9000_release_board calls release_resource with the platform resource
> instead of the requested resource:
>
> db->addr_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> db->addr_req = request_mem_region(db->addr_res->start, i, pdev->name);
>
> dm9000_release_board:
>
> if (db->addr_res != NULL) {
> release_resource(db->addr_res);
> kfree(db->addr_req);
>
> With this behavior the kernel will crash on the second removal. The
> attached patch fix this problem.
>
>
> Signed-off-by: Dirk Opfer <Dirk@Opfer-Online.de>
Acked-by: Ben Dooks <ben-linux@fluff.org>
next prev parent reply other threads:[~2006-08-31 9:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-30 7:04 [PATCH] Fix dm9000 release_resource Dirk Opfer
2006-08-31 9:39 ` Ben Dooks [this message]
2006-09-06 14:58 ` Jeff Garzik
2006-09-06 17:53 ` Dirk Opfer
2006-09-11 13:08 ` Jeff Garzik
[not found] <0ML25U-1GIK8C13Mq-0007lB@mrelayeu.kundenserver.de>
2006-08-31 7:32 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060831093940.GA3623@home.fluff.org \
--to=ben-linux@fluff.org \
--cc=Dirk@Opfer-Online.de \
--cc=ben@simtec.co.uk \
--cc=netdev@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.