From: Stephen Hemminger <shemminger@osdl.org>
To: Roland Dreier <rdreier@cisco.com>
Cc: netdev@vger.kernel.org
Subject: Re: NAPI: netif_rx_reschedule() ??
Date: Thu, 31 Aug 2006 14:29:10 -0700 [thread overview]
Message-ID: <20060831142910.427f64fa@localhost.localdomain> (raw)
In-Reply-To: <adalkp5lrod.fsf@cisco.com>
On Wed, 30 Aug 2006 16:39:14 -0700
Roland Dreier <rdreier@cisco.com> wrote:
> Roland> makes sense -- especially since the caller probably also
> Roland> deducted N from *budget, and netif_rx_reschedule() doesn't
> Roland> touch that.
>
> Actually, why does undoing the change to quota make sense? Presumably
> I passed N packets to netif_receive_skb() -- why shouldn't I deduct N
> from quota and *budget?
>
> - R.
This was probably a preventive thing to avoid scheduling when quota remaining was zero?
--
Stephen Hemminger <shemminger@osdl.org>
next prev parent reply other threads:[~2006-08-31 21:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-30 22:07 NAPI: netif_rx_reschedule() ?? Roland Dreier
2006-08-30 23:12 ` Stephen Hemminger
2006-08-30 23:31 ` Roland Dreier
2006-08-30 23:38 ` Stephen Hemminger
2006-08-30 23:39 ` Roland Dreier
2006-08-31 21:29 ` Stephen Hemminger [this message]
2006-08-31 21:50 ` jamal
2006-08-31 23:54 ` Alexey Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060831142910.427f64fa@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.