From: teigland@sourceware.org <teigland@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/group/gfs_controld recover.c
Date: 31 Aug 2006 18:56:26 -0000 [thread overview]
Message-ID: <20060831185626.11401.qmail@sourceware.org> (raw)
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: teigland at sourceware.org 2006-08-31 18:56:25
Modified files:
group/gfs_controld: recover.c
Log message:
When deciding whether we need to unlink the checkpoint and resend journals
for a failed master node we weren't distinguishing between the master
failing (where we need to do this stuff) and the master just leaving
(where we don't).
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/group/gfs_controld/recover.c.diff?cvsroot=cluster&r1=1.16&r2=1.17
--- cluster/group/gfs_controld/recover.c 2006/08/21 19:38:53 1.16
+++ cluster/group/gfs_controld/recover.c 2006/08/31 18:56:25 1.17
@@ -967,6 +967,7 @@
{
struct mg_member *memb, *safe;
int i, found, id, pos = 0, neg = 0, prev_master_nodeid;
+ int master_failed = 0;
/* move departed nodes from members list to members_gone */
@@ -1017,6 +1018,10 @@
memb->wait_gfs_recover_done);
purge_plocks(mg, memb->nodeid, 0);
+
+ if (mg->master_nodeid == memb->nodeid &&
+ memb->gone_type == GROUP_NODE_FAILED)
+ master_failed = 1;
}
}
@@ -1048,7 +1053,7 @@
- store plocks in ckpt for the new mounters to read when they
get the journals msg from us */
- if (neg &&
+ if (neg && master_failed &&
(prev_master_nodeid != -1) &&
(prev_master_nodeid != mg->master_nodeid) &&
(our_nodeid == mg->master_nodeid)) {
next reply other threads:[~2006-08-31 18:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-31 18:56 teigland [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-06-06 15:47 [Cluster-devel] cluster/group/gfs_controld recover.c teigland
2007-06-06 15:44 teigland
2006-12-19 22:20 teigland
2006-12-19 22:19 teigland
2006-12-19 22:19 teigland
2006-10-16 15:09 teigland
2006-08-21 19:38 teigland
2006-08-15 21:38 teigland
2006-08-10 19:40 teigland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060831185626.11401.qmail@sourceware.org \
--to=teigland@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.