From: Pavel Machek <pavel@ucw.cz>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Andrew Morton <akpm@osdl.org>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: cpu_init is called during resume
Date: Fri, 1 Sep 2006 00:31:21 +0200 [thread overview]
Message-ID: <20060831223121.GG12847@elf.ucw.cz> (raw)
In-Reply-To: <44F70A4B.4090803@goop.org>
Hi!
> >cpu_init() is called during resume, at time when GFP_KERNEL is not
> >available. This silences warning, and adds few small cleanups.
> >
>
> I presume this is resume from disk. If you're doing resume from RAM,
> all the CPU-related stuff should already be allocated, unless you're
> bringing up a new CPU which wasn't previously there, right?
We are doing virtual cpu hotplug/unplug... actually suspend to RAM
*and* disk. Just try it :-).
> And wouldn't making these allocations atomic make real CPU hotplug (ie,
> on an active, running system) more likely to fail? This code doesn't
> deal with allocation failure very elegantly.
Hmm... well hopefully free_pages_min will cover this case.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2006-08-31 22:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-31 13:55 cpu_init is called during resume Pavel Machek
2006-08-31 16:11 ` Jeremy Fitzhardinge
2006-08-31 22:31 ` Pavel Machek [this message]
2006-08-31 23:52 ` Jeremy Fitzhardinge
2006-09-02 11:21 ` Pavel Machek
2006-09-03 0:00 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060831223121.GG12847@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@osdl.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.