Re: [PATCH -mm] lib/ts_fsm.c: constify structs

[Thomas Graf <tgraf@suug.ch>]

* Andreas Mohr <andi@rhlx01.fht-esslingen.de> 2006-09-01 14:51
> Hi,
> 
> On Fri, Sep 01, 2006 at 01:31:37PM +0200, Thomas Graf wrote:
> > * Andreas Mohr <andi@rhlx01.fht-esslingen.de> 2006-08-31 20:27
> > > @@ -44,7 +44,7 @@
> > >  #define _W		0x200 /* wildcard */
> > >  
> > >  /* Map to _ctype flags and some magic numbers */
> > > -static u16 token_map[TS_FSM_TYPE_MAX+1] = {
> > > +static const u16 token_map[TS_FSM_TYPE_MAX+1] = {
> > >  	[TS_FSM_SPECIFIC] = 0,
> > >  	[TS_FSM_WILDCARD] = _W,
> > >  	[TS_FSM_CNTRL]	  = _C,
> > > @@ -61,7 +61,7 @@
> > >  	[TS_FSM_ASCII]	  = _A,
> > >  };
> > >  
> > > -static u16 token_lookup_tbl[256] = {
> > > +static const u16 token_lookup_tbl[256] = {
> > >  _W|_A|_C,      _W|_A|_C,     _W|_A|_C,     _W|_A|_C,		/*   0-  3 */
> > >  _W|_A|_C,      _W|_A|_C,     _W|_A|_C,     _W|_A|_C,		/*   4-  7 */
> > >  _W|_A|_C,      _W|_A|_C|_S,  _W|_A|_C|_S,  _W|_A|_C|_S,		/*   8- 11 */
> > 
> > You could mark them __read_mostly at this opportunity.
> 
> Thanks for the review!
> 
> However being const already implies __read_mostly if I'm not mistaken,
> due to its const nature which doesn't allow any modification. ;)

Right, not sure what I was thinking. ;) However, gcc probably already
put it into rodata for being static and only referenced for reading
so it probably doesn't make any difference.