[PATCH] ac97: Fix AD1819 PCM volume range

[PATCH] ac97: Fix AD1819 PCM volume range

[syrjala]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: ac97_fix_ad1819_pcm_volume_range.patch --]
[-- Type: text/plain, Size: 1123 bytes --]

AD1819 PCM volume register can hold one extra bit per channel which do
not affect the actual volume. Add a res_table to the codec patch to fix
the problem.

Signed-off-by: Ville Syrjala <syrjala@sci.fi>
---

 sound/pci/ac97/ac97_patch.c |    6 ++++++
 1 file changed, 6 insertions(+)

Index: linux-2.6.18-rc5-vs/sound/pci/ac97/ac97_patch.c
===================================================================
--- linux-2.6.18-rc5-vs.orig/sound/pci/ac97/ac97_patch.c
+++ linux-2.6.18-rc5-vs/sound/pci/ac97/ac97_patch.c
@@ -1380,6 +1380,11 @@ static void ad1888_resume(struct snd_ac9
 
 #endif
 
+static const struct snd_ac97_res_table ad1819_restbl[] = {
+	{ AC97_PCM, 0x9f1f },
+	{ } /* terminator */
+};
+
 int patch_ad1819(struct snd_ac97 * ac97)
 {
 	unsigned short scfg;
@@ -1387,6 +1392,7 @@ int patch_ad1819(struct snd_ac97 * ac97)
 	// patch for Analog Devices
 	scfg = snd_ac97_read(ac97, AC97_AD_SERIAL_CFG);
 	snd_ac97_write_cache(ac97, AC97_AD_SERIAL_CFG, scfg | 0x7000); /* select all codecs */
+	ac97->res_table = ad1819_restbl;
 	return 0;
 }
 

-- 
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/


[-- Attachment #2: Type: text/plain, Size: 373 bytes --]

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

[-- Attachment #3: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel

Re: [PATCH] ac97: Fix AD1819 PCM volume range

[Ville Syrjälä]

On Sun, Sep 03, 2006 at 05:07:54AM +0300, syrjala@sci.fi wrote:
> AD1819 PCM volume register can hold one extra bit per channel which do
> not affect the actual volume. Add a res_table to the codec patch to fix
> the problem.

Actually, scrap this patch. It looks like other controls suffer from the 
same problem. I'll send an updated patch shortly...

-- 
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642