All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kay Sievers <kay.sievers@vrfy.org>
To: linux-hotplug@vger.kernel.org
Subject: Re: scripts for persistent names support
Date: Sun, 03 Sep 2006 12:48:38 +0000	[thread overview]
Message-ID: <20060903124837.GA7476@vrfy.org> (raw)
In-Reply-To: <20060902090653.GA4424@wonderland.linux.it>

On Sun, Sep 03, 2006 at 12:10:09PM +0200, Marco d'Itri wrote:
> On Sep 03, Kay Sievers <kay.sievers@vrfy.org> wrote:
> 
> > > . /lib/udev/hotplug.functions
> > Can we name that file udev.functions?
> Done.

Thanks.

> > > device_description() {
> > >   local bus=$(sysreadlink device/bus)
> > >   bus=${bus##*/}
> > We should not use the 'device' link. It's only a comment, but it's
> > a nice information. Can't we read this information with udev rules
> > and export it as an environment variable or pass it as an argument.
> How? Exporting every attribute which can possibly be used look like a
> lot of work.

Something like this could work?
  SUBSYSTEMS="pci", ENV{COMMENT}="PCI Device: $attr{vendor}:$attr{product}"
  SUBSYSTEMS="usb", ENV{COMMENT}="USB Device: 0x$attr{idVendor}:0x$attr{idProduct}"
  SUBSYSTEMS="ieee1394", ENV{COMMENT}="Firewire Device: $attr{host_id}"
  SUBSYSTEMS="xen", ENV{COMMENT}="Xen virtual device"

> > Can't we check with the rule writing script itself, if there are
> > already created temporary rules, and if yes, we just copy them over?
> > That way, the failed-event-replay would just take care of copying for
> > systems who use the --retry-failed?
> No, because the idea is that these failed events will not be replayed.

Why not? If the called program looks first if there is already a temp
rule for the device, it will try to make the temp rule a real rule,
that's all.
That way, you would not need a start script to do the work if you
already use the retry-failed, and if you don't use the retry-failed,
it will not hurt anything.
The point is that the same code would just work fine without any changes
in both cases, which is nice.

> > > # ignore interfaces without a driver link
> > > ENV{DRIVER}!="?*", GOTO="persistent_net_generator_end"
> > Does this work? A network device event should never have the DRIVER
> > property set, as it belongs to a parent device.
> Indeed it does not work anymore...
> Originally it used ENV{PHYSDEVDRIVER}, what should I use now? DRIVERS
> does not work either.

DRIVERS="?*", indicates that one of your parents is created by a bus
driver. This should create a rule that only runs for a non-virtual
device.

One other thing, we should not assume that rules files are symlinks in
the comments in the headers. Symlinks break the automatic rule reload
on file changes.

Kay

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid\x120709&bid&3057&dat\x121642
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

      parent reply	other threads:[~2006-09-03 12:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-02  9:06 scripts for persistent names support Marco d'Itri
2006-09-03  3:16 ` Kay Sievers
2006-09-03 10:10 ` Marco d'Itri
2006-09-03 12:48 ` Kay Sievers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060903124837.GA7476@vrfy.org \
    --to=kay.sievers@vrfy.org \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.