Re: [PATCH] pack-objects: re-validate data we copy from elsewhere.

[Shawn Pearce <spearce@spearce.org>]

Junio C Hamano <junkio@cox.net> wrote:
> Shawn Pearce <spearce@spearce.org> writes:
> 
> > Junio C Hamano <junkio@cox.net> wrote:
> >
> >> If rev-list had an extention that lets you say
> >> 
> >> 	rev-list --objects --all --unpacked=$active_pack |
> >> 	pack-objects $new_pack
> >
> > Hmm.  Seems very reasonable actually.  :-)
> >
> > How do we pick the "active pack" in git-repack.sh?
> 
> I was hoping that will be a Porcelain policy issue I do not have
> to decide ;-).

But would need to update git-repack.sh.  :-)
 
> You could introduce repack.active in .git/config that points at
> the latest active, make git-repack to notice and update when it
> updates it.

No.  I don't think its a good idea for git-repack to be updating
your configuration file during a repack.  If something goes badly
there you could lose settings you would rather not lose.

Better that it update a symref like thing instead.  For example
create a ".git/objects/pack/active" file holding the name
("pack-n{40}.pack") of the current active pack.  If this file is
missing choose the pack that is smallest as the active pack.

-- 
Shawn.

-- 
VGER BF report: S 0.999999