From: Dmitry Mishin <dim@openvz.org>
To: netfilter-devel@lists.netfilter.org
Subject: check_entry & module_refcount
Date: Mon, 4 Sep 2006 16:17:39 +0400 [thread overview]
Message-ID: <200609041617.39950.dim@openvz.org> (raw)
Hello, all!
Does anybody know why there is no module_put() on the error way after failed
standard_check() call in the check_entry() function? Previous xt_find_target()
calls try_module_get() for all targets, without special checks for
standard_target.
If it is a bug, patch over net-2.6.19 is below.
Signed-off-by: Dmitry Mishin <dim@openvz.org>
--
ip_tables.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- ./net/ipv4/netfilter/ip_tables.c.err 2006-08-30 13:12:13.000000000 +0400
+++ ./net/ipv4/netfilter/ip_tables.c 2006-09-04 16:01:11.000000000 +0400
@@ -573,7 +573,7 @@
if (t->u.kernel.target == &ipt_standard_target) {
if (!standard_check(t, size)) {
ret = -EINVAL;
- goto cleanup_matches;
+ goto err;
}
} else if (t->u.kernel.target->checkentry
&& !t->u.kernel.target->checkentry(name, e, target, t->data,
next reply other threads:[~2006-09-04 12:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-04 12:17 Dmitry Mishin [this message]
2006-09-04 13:40 ` check_entry & module_refcount Patrick McHardy
2006-09-06 1:24 ` Yasuyuki KOZAKAI
2006-09-06 18:23 ` Patrick McHardy
2006-09-07 10:08 ` small check_entry & module_refcount cleanup Dmitry Mishin
2006-09-07 15:02 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200609041617.39950.dim@openvz.org \
--to=dim@openvz.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.